Differential D3609

loader: Update swh.storage.origin_get call to latest api change
ClosedPublic
Actions

Authored by ardumont on Jul 24 2020, 8:51 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDLDSVNe99c68b8df9a: loader: Update swh.storage.origin_get call to latest api change

Summary

Related to T645

Test Plan

tox

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 24 2020, 8:51 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 24 2020, 8:51 AM

Build has FAILED

Patch application report for D3609 (id=12706)

Rebasing onto b055be0903...

Current branch diff-target is up to date.

Changes applied before test

commit 53d83939c05cf332966741f3fce688ef514a12d8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 08:51:18 2020 +0200

    loader: Update swh.storage.origin_get call to latest api change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/84/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/84/console

Harbormaster failed remote builds in B13932: Diff 12706!Jul 24 2020, 8:51 AM

Update so tests are properly failing (and will go green when new storage is released)

Build has FAILED

Patch application report for D3609 (id=12707)

Rebasing onto b055be0903...

Current branch diff-target is up to date.

Changes applied before test

commit e99c68b8df9a3a986dea67e5c281d9a2d47ff5d4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 08:51:18 2020 +0200

    loader: Update swh.storage.origin_get call to latest api change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/85/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/85/console

Harbormaster failed remote builds in B13933: Diff 12707!Jul 24 2020, 9:05 AM

Why do you need to bump the storage version?

This revision is now accepted and ready to land.Jul 24 2020, 9:18 AM

Why do you need to bump the storage version?

because the origin-get currently does not take plain iterable of urls as arguments.
that's D3605 ;)

ardumont edited the test plan for this revision. (Show Details)Jul 27 2020, 8:31 AM

Build is green

Patch application report for D3609 (id=12707)

Rebasing onto b055be0903...

Current branch diff-target is up to date.

Changes applied before test

commit e99c68b8df9a3a986dea67e5c281d9a2d47ff5d4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 08:51:18 2020 +0200

    loader: Update swh.storage.origin_get call to latest api change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/86/ for more details.

Harbormaster completed remote builds in B13933: Diff 12707.Jul 27 2020, 8:34 AM

Closed by commit rDLDSVNe99c68b8df9a: loader: Update swh.storage.origin_get call to latest api change (authored by ardumont). · Explain WhyJul 27 2020, 8:38 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVNe99c68b8df9a: loader: Update swh.storage.origin_get call to latest api change.