Page MenuHomeSoftware Heritage

loader: Update swh.storage.origin_get call to latest api change
ClosedPublic

Authored by ardumont on Fri, Jul 24, 8:51 AM.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Fri, Jul 24, 8:51 AM

Build has FAILED

Patch application report for D3609 (id=12706)

Rebasing onto b055be0903...

Current branch diff-target is up to date.
Changes applied before test
commit 53d83939c05cf332966741f3fce688ef514a12d8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 08:51:18 2020 +0200

    loader: Update swh.storage.origin_get call to latest api change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/84/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/84/console

ardumont updated this revision to Diff 12707.Fri, Jul 24, 9:05 AM

Update so tests are properly failing (and will go green when new storage is released)

Build has FAILED

Patch application report for D3609 (id=12707)

Rebasing onto b055be0903...

Current branch diff-target is up to date.
Changes applied before test
commit e99c68b8df9a3a986dea67e5c281d9a2d47ff5d4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 08:51:18 2020 +0200

    loader: Update swh.storage.origin_get call to latest api change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/85/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/85/console

vlorentz accepted this revision.Fri, Jul 24, 9:18 AM
vlorentz added a subscriber: vlorentz.

Why do you need to bump the storage version?

This revision is now accepted and ready to land.Fri, Jul 24, 9:18 AM

Why do you need to bump the storage version?

because the origin-get currently does not take plain iterable of urls as arguments.
that's D3605 ;)

ardumont edited the test plan for this revision. (Show Details)Mon, Jul 27, 8:31 AM

Build is green

Patch application report for D3609 (id=12707)

Rebasing onto b055be0903...

Current branch diff-target is up to date.
Changes applied before test
commit e99c68b8df9a3a986dea67e5c281d9a2d47ff5d4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 08:51:18 2020 +0200

    loader: Update swh.storage.origin_get call to latest api change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/86/ for more details.