Differential D3607

migrations: Update swh.storage.origin_get calls to latest api change
ClosedPublic
Actions

Authored by ardumont on Jul 24 2020, 8:14 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDDEP402e4b83bb46: migrations: Update swh.storage.origin_get calls to latest api change

Summary

For the sake of staying consistent everywhere.

Related to T645

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13928
Build 21369: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21368: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 24 2020, 8:14 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 24 2020, 8:14 AM

Fix calls, origin-get takes the identifier (origin url here), not an Origin object!

Build is green

Patch application report for D3607 (id=12701)

Rebasing onto 12ce6488bd...

Current branch diff-target is up to date.

Changes applied before test

commit cb5009af5727a8c005a9f76fd8a155e537e26e2e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 08:11:14 2020 +0200

    migrations: Update swh.storage.origin_get calls to latest api change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/45/ for more details.

Harbormaster completed remote builds in B13927: Diff 12701.Jul 24 2020, 8:18 AM

Build is green

Patch application report for D3607 (id=12702)

Rebasing onto 12ce6488bd...

Current branch diff-target is up to date.

Changes applied before test

commit 402e4b83bb463d21c6b684df92b832dbe5501bfd
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 24 08:11:14 2020 +0200

    migrations: Update swh.storage.origin_get calls to latest api change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/46/ for more details.

Harbormaster completed remote builds in B13928: Diff 12702.Jul 24 2020, 8:21 AM

ardumont edited the test plan for this revision. (Show Details)Jul 24 2020, 8:23 AM

ardumont edited the summary of this revision. (Show Details)Jul 24 2020, 8:51 AM

vlorentz accepted this revision.Jul 24 2020, 9:15 AM

This revision is now accepted and ready to land.Jul 24 2020, 9:15 AM

Closed by commit rDDEP402e4b83bb46: migrations: Update swh.storage.origin_get calls to latest api change (authored by ardumont). · Explain WhyJul 27 2020, 8:33 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP402e4b83bb46: migrations: Update swh.storage.origin_get calls to latest api change.