Differential D3574

test_storage: test_object_find_by_sha1: Use data model object
ClosedPublic
Actions

Authored by ardumont on Jul 20 2020, 5:58 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTOc9e921eb45d5: test_storage: test_object_find_by_sha1: Use data model object

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13806
Build 21160: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21159: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 20 2020, 5:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 5:58 PM

vlorentz accepted this revision.Jul 20 2020, 6:08 PM

This revision is now accepted and ready to land.Jul 20 2020, 6:08 PM

Build is green

Patch application report for D3574 (id=12581)

Could not rebase; Attempt merge onto 1c1bef91e1...

Updating 1c1bef91..c9e921eb
Fast-forward
 swh/storage/tests/test_storage.py | 755 ++++++++++++++++++++------------------
 1 file changed, 396 insertions(+), 359 deletions(-)

Changes applied before test

commit c9e921eb45d5257589ed35bf7498aa4d5cb78c94
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 17:59:00 2020 +0200

    test_storage: test_object_find_by_sha1: Use data model object
    
    Related to T2494

commit caa7f7947992f2c9979f9038eceba290c8cf105f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 17:39:02 2020 +0200

    test_storage: content_find: Use data model object
    
    Related to T2494

commit 64535049b02de6ad0c43d9f55d1093d1a8a4d8e2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 16:35:46 2020 +0200

    test_storage: stat_counters: Use data model object
    
    Related to T2494

commit cf80d3c29d7a7f2094570c14478fcc93dd995a12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:58:35 2020 +0200

    test_storage: snapshot: Use data model object
    
    Related to T2494

commit 4f1017173b98cbc742a45d1b44ea5716dcab29a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:36:05 2020 +0200

    test_storage: origin_visit/origin_visit_status: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/507/ for more details.

Harbormaster completed remote builds in B13806: Diff 12581.Jul 20 2020, 6:15 PM

Closed by commit rDSTOc9e921eb45d5: test_storage: test_object_find_by_sha1: Use data model object (authored by ardumont). · Explain WhyJul 20 2020, 6:16 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOc9e921eb45d5: test_storage: test_object_find_by_sha1: Use data model object.