Differential D3573

test_storage: content_find: Use data model object
ClosedPublic
Actions

Authored by ardumont on Jul 20 2020, 5:46 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTOcaa7f7947992: test_storage: content_find: Use data model object

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13805
Build 21158: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21157: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 20 2020, 5:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 5:46 PM

Build has FAILED

Patch application report for D3573 (id=12578)

Could not rebase; Attempt merge onto 1c1bef91e1...

Updating 1c1bef91..843ecfb6
Fast-forward
 swh/storage/tests/test_storage.py | 719 ++++++++++++++++++++------------------
 1 file changed, 377 insertions(+), 342 deletions(-)

Changes applied before test

commit 843ecfb6c124525ea34873505f6d766056fb09f2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 17:39:02 2020 +0200

    test_storage: content_find: Use data model object
    
    Related to T2494

commit 1bf74dcd90ef2b333af9b465de7a23f48c53993d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 16:35:46 2020 +0200

    test_storage: stat_counters: Use data model object
    
    Related to T2494

commit cf80d3c29d7a7f2094570c14478fcc93dd995a12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:58:35 2020 +0200

    test_storage: snapshot: Use data model object
    
    Related to T2494

commit 4f1017173b98cbc742a45d1b44ea5716dcab29a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:36:05 2020 +0200

    test_storage: origin_visit/origin_visit_status: Use data model object
    
    Related to T2494

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/504/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/504/console

Harbormaster failed remote builds in B13803: Diff 12578!Jul 20 2020, 5:53 PM

Rebase

Build is green

Patch application report for D3573 (id=12580)

Could not rebase; Attempt merge onto 1c1bef91e1...

Updating 1c1bef91..caa7f794
Fast-forward
 swh/storage/tests/test_storage.py | 717 ++++++++++++++++++++------------------
 1 file changed, 376 insertions(+), 341 deletions(-)

Changes applied before test

commit caa7f7947992f2c9979f9038eceba290c8cf105f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 17:39:02 2020 +0200

    test_storage: content_find: Use data model object
    
    Related to T2494

commit 64535049b02de6ad0c43d9f55d1093d1a8a4d8e2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 16:35:46 2020 +0200

    test_storage: stat_counters: Use data model object
    
    Related to T2494

commit cf80d3c29d7a7f2094570c14478fcc93dd995a12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:58:35 2020 +0200

    test_storage: snapshot: Use data model object
    
    Related to T2494

commit 4f1017173b98cbc742a45d1b44ea5716dcab29a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:36:05 2020 +0200

    test_storage: origin_visit/origin_visit_status: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/506/ for more details.

Harbormaster completed remote builds in B13805: Diff 12580.Jul 20 2020, 6:08 PM

vlorentz accepted this revision.Jul 20 2020, 6:08 PM

This revision is now accepted and ready to land.Jul 20 2020, 6:08 PM

Closed by commit rDSTOcaa7f7947992: test_storage: content_find: Use data model object (authored by ardumont). · Explain WhyJul 20 2020, 6:16 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOcaa7f7947992: test_storage: content_find: Use data model object.