Differential D3569

test_storage: revision/release: Drop no longer needed conditionals
ClosedPublic
Actions

Authored by ardumont on Jul 20 2020, 2:52 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTO1c1bef91e1b6: test_storage: revision/release: Drop no longer needed conditionals

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13795
Build 21140: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21139: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 20 2020, 2:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 2:52 PM

Build is green

Patch application report for D3569 (id=12570)

Could not rebase; Attempt merge onto bbdd7ed48d...

Updating bbdd7ed4..1c1bef91
Fast-forward
 swh/storage/tests/test_storage.py | 270 +++++++++++++++++---------------------
 1 file changed, 121 insertions(+), 149 deletions(-)

Changes applied before test

commit 1c1bef91e1b65f62d939405cbcb3356aa34fc61c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 14:52:37 2020 +0200

    test_storage: revision/release: Drop no longer needed conditionals
    
    Related to T2494

commit cdf6f580817cd6b3c1995a2d76eb5470b1f1abc7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 14:34:24 2020 +0200

    test_storage: origin: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/499/ for more details.

Harbormaster completed remote builds in B13795: Diff 12570.Jul 20 2020, 3:04 PM

vlorentz accepted this revision.Jul 20 2020, 3:15 PM

This revision is now accepted and ready to land.Jul 20 2020, 3:15 PM

Closed by commit rDSTO1c1bef91e1b6: test_storage: revision/release: Drop no longer needed conditionals (authored by ardumont). · Explain WhyJul 20 2020, 3:16 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO1c1bef91e1b6: test_storage: revision/release: Drop no longer needed conditionals.