Differential D3557

test_storage: skipped_content/content_missing: Use data model object
ClosedPublic
Actions

Authored by ardumont on Jul 20 2020, 10:15 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTO03e17c3600f3: test_storage: skipped_content/content_missing: Use data model object

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 20 2020, 10:15 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 10:15 AM

Build is green

Patch application report for D3557 (id=12536)

Rebasing onto 997ec1dbf7...

Current branch diff-target is up to date.

Changes applied before test

commit 0a5b5d82ede3e67fc6862c8e07924d4e98a6c162
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 10:12:13 2020 +0200

    test_storage: skipped_content/content_missing: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/479/ for more details.

Harbormaster completed remote builds in B13759: Diff 12536.Jul 20 2020, 10:21 AM

vlorentz accepted this revision.Jul 20 2020, 10:31 AM

This revision is now accepted and ready to land.Jul 20 2020, 10:31 AM

Rebase on latest master

Build has FAILED

Patch application report for D3557 (id=12543)

Rebasing onto 7131dcb9cf...

Current branch diff-target is up to date.

Changes applied before test

commit 03e17c3600f340e077d835f19cba05893d114612
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 10:12:13 2020 +0200

    test_storage: skipped_content/content_missing: Use data model object
    
    Related to T2494

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/483/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/483/console

Harbormaster failed remote builds in B13766: Diff 12543!Jul 20 2020, 11:08 AM

Build is green

Patch application report for D3557 (id=12543)

Rebasing onto 7131dcb9cf...

Current branch diff-target is up to date.

Changes applied before test

commit 03e17c3600f340e077d835f19cba05893d114612
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 10:12:13 2020 +0200

    test_storage: skipped_content/content_missing: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/486/ for more details.

Harbormaster completed remote builds in B13766: Diff 12543.Jul 20 2020, 11:29 AM

Closed by commit rDSTO03e17c3600f3: test_storage: skipped_content/content_missing: Use data model object (authored by ardumont). · Explain WhyJul 20 2020, 12:02 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO03e17c3600f3: test_storage: skipped_content/content_missing: Use data model object.