Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Maniphest Tasks
- T2494: tests: Use data model objects within tests (drop dicts)
- Commits
- rDLDBASE5acfe7479a48: check_snapshot: Drop accepting using dict for snapshot comparison
tox
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3543 (id=12495)
Could not rebase; Attempt merge onto cede65ed1f...
Updating cede65e..5acfe74 Fast-forward swh/loader/package/nixguix/tests/test_nixguix.py | 228 ++++++++++------------- swh/loader/package/npm/tests/test_npm.py | 163 +++++++++------- swh/loader/package/pypi/tests/test_pypi.py | 220 ++++++++++++---------- swh/loader/tests/__init__.py | 6 +- swh/loader/tests/test_init.py | 9 +- 5 files changed, 318 insertions(+), 308 deletions(-)
Changes applied before test
commit 5acfe7479a48858950ef80ff201ef9c2d6521619 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Thu Jul 16 19:04:12 2020 +0200 check_snapshot: Drop accepting using dict for snapshot comparison Related to T2494 commit 01f273d5d87bbcc49ad3be48e943b25e43fceaa0 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Thu Jul 16 18:59:04 2020 +0200 test_pypi: Check against snapshot model object Related to T2494 commit 56b024b8fc3b93ee1b9d4fce465453ed2e554c7c Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Thu Jul 16 18:40:33 2020 +0200 test_npm: Check against snapshot model object Related to T2494 commit 4df9a4a09790c690d9888d704c6b66c894180e80 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Thu Jul 16 18:23:32 2020 +0200 test_nixguix: Merge check_snapshot* methods into 1 commit 7c2b3668052a97e7e7b25fa0687b412b2010ebeb Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Thu Jul 16 18:22:18 2020 +0200 test_nixguix: Check against snapshot model object Related to T2494
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/177/ for more details.