Differential D3541

test_npm: Check against snapshot model object
ClosedPublic
Actions

Authored by ardumont on Jul 16 2020, 6:40 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDLDBASE56b024b8fc3b: test_npm: Check against snapshot model object

Summary

Related to T2494

(This adds some missing assertions on the visit status)

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13716
Build 21016: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21015: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 16 2020, 6:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2020, 6:40 PM

ardumont edited the summary of this revision. (Show Details)Jul 16 2020, 6:41 PM

Build is green

Patch application report for D3541 (id=12492)

Could not rebase; Attempt merge onto cede65ed1f...

Updating cede65e..45163f0
Fast-forward
 swh/loader/package/nixguix/tests/test_nixguix.py | 224 ++++++++++-------------
 swh/loader/package/npm/tests/test_npm.py         | 153 +++++++++-------
 2 files changed, 183 insertions(+), 194 deletions(-)

Changes applied before test

commit 45163f02e1c5a078717acb92ce241e2149d0ce84
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 18:40:33 2020 +0200

    test_npm: Check against snapshot model object
    
    Related to T2494

commit 4df9a4a09790c690d9888d704c6b66c894180e80
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 18:23:32 2020 +0200

    test_nixguix: Merge check_snapshot* methods into 1

commit 7c2b3668052a97e7e7b25fa0687b412b2010ebeb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 18:22:18 2020 +0200

    test_nixguix: Check against snapshot model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/174/ for more details.

Harbormaster completed remote builds in B13716: Diff 12492.Jul 16 2020, 6:42 PM

Add missing some assertions

Build is green

Patch application report for D3541 (id=12493)

Could not rebase; Attempt merge onto cede65ed1f...

Updating cede65e..56b024b
Fast-forward
 swh/loader/package/nixguix/tests/test_nixguix.py | 224 ++++++++++-------------
 swh/loader/package/npm/tests/test_npm.py         | 163 ++++++++++-------
 2 files changed, 191 insertions(+), 196 deletions(-)

Changes applied before test

commit 56b024b8fc3b93ee1b9d4fce465453ed2e554c7c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 18:40:33 2020 +0200

    test_npm: Check against snapshot model object
    
    Related to T2494

commit 4df9a4a09790c690d9888d704c6b66c894180e80
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 18:23:32 2020 +0200

    test_nixguix: Merge check_snapshot* methods into 1

commit 7c2b3668052a97e7e7b25fa0687b412b2010ebeb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 18:22:18 2020 +0200

    test_nixguix: Check against snapshot model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/175/ for more details.

Harbormaster completed remote builds in B13717: Diff 12493.Jul 16 2020, 6:46 PM

douardda accepted this revision.Jul 17 2020, 11:07 AM

This revision is now accepted and ready to land.Jul 17 2020, 11:07 AM

Closed by commit rDLDBASE56b024b8fc3b: test_npm: Check against snapshot model object (authored by ardumont). · Explain WhyJul 17 2020, 11:22 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASE56b024b8fc3b: test_npm: Check against snapshot model object.