Differential D3529

algos.test_snapshot: Use model objects from sample_data_model
ClosedPublic
Actions

Authored by ardumont on Jul 16 2020, 3:19 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTO97a07211e87c: algos.test_snapshot: Use model objects from sample_data_model

Summary

This opens up origin_visits and add new snapshots to the fixture. So we can
reuse those.

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13689
Build 20972: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20971: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 16 2020, 3:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2020, 3:19 PM

Build is green

Patch application report for D3529 (id=12465)

Rebasing onto b6971b5139...

Current branch diff-target is up to date.

Changes applied before test

commit bd9a0aed5326c4a07d781e63d0ee2051cac77211
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 15:17:33 2020 +0200

    algos.test_snapshot: Use model objects from sample_data_model
    
    This opens up origin_visits and add new snapshots to the fixture. So we can
    reuse those.
    
    Related to 2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/467/ for more details.

Harbormaster completed remote builds in B13689: Diff 12465.Jul 16 2020, 3:25 PM

ardumont edited the summary of this revision. (Show Details)Jul 16 2020, 3:33 PM

ardumont added a task: T2494: tests: Use data model objects within tests (drop dicts).

Fix typo in commit message

Build is green

Patch application report for D3529 (id=12466)

Rebasing onto b6971b5139...

Current branch diff-target is up to date.

Changes applied before test

commit 97a07211e87c5e2cfdbb8594549e5000ea316037
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 15:17:33 2020 +0200

    algos.test_snapshot: Use model objects from sample_data_model
    
    This opens up origin_visits and add new snapshots to the fixture. So we can
    reuse those.
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/468/ for more details.

Harbormaster completed remote builds in B13690: Diff 12466.Jul 16 2020, 3:40 PM

anlambert accepted this revision.Jul 16 2020, 4:57 PM

This revision is now accepted and ready to land.Jul 16 2020, 4:57 PM

Closed by commit rDSTO97a07211e87c: algos.test_snapshot: Use model objects from sample_data_model (authored by ardumont). · Explain WhyJul 16 2020, 5:04 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO97a07211e87c: algos.test_snapshot: Use model objects from sample_data_model.