Page MenuHomeSoftware Heritage

Fix test_from_disk's snapshot "id" type for bytes
ClosedPublic

Authored by douardda on Jul 16 2020, 9:55 AM.

Details

Summary

instead of str.

Test Plan

This should pass with current swh.loader.core version as well as with D3501.

Diff Detail

Event Timeline

Build is green

Patch application report for D3517 (id=12427)

Rebasing onto c895b468ca...

Current branch diff-target is up to date.
Changes applied before test
commit b045eed118e53720f472d4422190325d3732f1eb
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Jul 16 09:53:38 2020 +0200

    Fix test_from_disk's snapshot "id" type for bytes
    
    instead of str.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/42/ for more details.

ardumont added a subscriber: ardumont.

For the sake of checking if my comment makes sense (i think it does heh).
(I did a similar remark in D3516, can you please have a look?)

swh/loader/git/tests/test_from_disk.py
30

I think you can inline it as bytes now.

This revision now requires changes to proceed.Jul 16 2020, 9:59 AM
swh/loader/git/tests/test_from_disk.py
30

as in:

"id": hash_to_bytes("a23699280a82a043f8c0994cf1631b568f716f95")

(SNAPSHOT_ID is only used here)

This revision is now accepted and ready to land.Jul 16 2020, 10:33 AM

Build is green

Patch application report for D3517 (id=12430)

Rebasing onto c895b468ca...

Current branch diff-target is up to date.
Changes applied before test
commit a6dd6356e412aa0cc499e0166a2b921ed6594b97
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Jul 16 09:53:38 2020 +0200

    Fix test_from_disk's snapshot "id" type for bytes
    
    instead of str.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/43/ for more details.