Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2483: tests: Make check-snapshot utility test function recursively check targetted object exists

Commits

rDLDBASE54cc0adc5b1e: check_snapshot: Check existence up to the first level directories

Summary

... targeted by revisions

Related to T2483

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13606
Build 20834: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20833: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 10 2020, 5:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 10 2020, 5:40 PM

Update tests docstring about unsupported test case

Build is green

Patch application report for D3502 (id=12381)

Rebasing onto 9f04d72516...

Current branch diff-target is up to date.

Changes applied before test

commit 9e878e930c4a5c4be3aaa10abb67e35bf03b8bd7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 17:39:54 2020 +0200

    check_snapshot: Check existence up to the first level directories
    
    targeted by revisions
    
    Related to T2484

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/149/ for more details.

Harbormaster completed remote builds in B13604: Diff 12381.Jul 10 2020, 5:42 PM

Build is green

Patch application report for D3502 (id=12382)

Rebasing onto 9f04d72516...

Current branch diff-target is up to date.

Changes applied before test

commit 82f2a73b00609f01b0aa6fe5d606b6ba8c119983
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 17:39:54 2020 +0200

    check_snapshot: Check existence up to the first level directories
    
    targeted by revisions
    
    Related to T2484

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/150/ for more details.

Harbormaster completed remote builds in B13605: Diff 12382.Jul 10 2020, 5:44 PM

Drop wrong and unused variable instruction

Build is green

Patch application report for D3502 (id=12383)

Rebasing onto 9f04d72516...

Current branch diff-target is up to date.

Changes applied before test

commit e45e9fc1ef369390ccf49e7110f68b259779fb8e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 17:39:54 2020 +0200

    check_snapshot: Check existence up to the first level directories
    
    targeted by revisions
    
    Related to T2484

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/151/ for more details.

Harbormaster completed remote builds in B13606: Diff 12383.Jul 10 2020, 5:51 PM

ardumont retitled this revision from check_snapshot: Check existence up to the first level directories to check_snapshot: Check existence down to the first level directories.Jul 10 2020, 6:14 PM

Clarify commnents and drops unneeded checks

Build is green

Patch application report for D3502 (id=12385)

Rebasing onto 9f04d72516...

Current branch diff-target is up to date.

Changes applied before test

commit 54cc0adc5b1e42b3cd9951781530b62f6515648d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 17:39:54 2020 +0200

    check_snapshot: Check existence up to the first level directories
    
    targeted by revisions
    
    Related to T2484

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/153/ for more details.

Harbormaster completed remote builds in B13608: Diff 12385.Jul 10 2020, 6:21 PM

ardumont removed a task: T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin.Jul 10 2020, 7:01 PM

ardumont added a task: T2483: tests: Make check-snapshot utility test function recursively check targetted object exists.

ardumont edited the summary of this revision. (Show Details)

ardumont added a child revision: D3503: check_snapshot: Check existence down to contents.Jul 15 2020, 9:27 AM

douardda accepted this revision.Jul 15 2020, 10:51 AM

This revision is now accepted and ready to land.Jul 15 2020, 10:51 AM

Closed by commit rDLDBASE54cc0adc5b1e: check_snapshot: Check existence up to the first level directories (authored by ardumont). · Explain WhyJul 15 2020, 11:06 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASE54cc0adc5b1e: check_snapshot: Check existence up to the first level directories.