Differential D3500

in_memory: Fix snapshot_get_branches regression with target_types
ClosedPublic
Actions

Authored by anlambert on Jul 10 2020, 4:06 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTO9219a23606c8: in_memory: Fix snapshot_get_branches regression with target_types

Summary

When providing target_types parameter, snapshot branches must be sorted when
iterating otherwise wrong branches can be returned.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 10 2020, 4:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 10 2020, 4:06 PM

Build is green

Patch application report for D3500 (id=12363)

Rebasing onto 23318c21d1...

Current branch diff-target is up to date.

Changes applied before test

commit 5513ff4bb18e4febb0945b559dd83b7b01b3d3bf
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jul 10 16:02:30 2020 +0200

    in_memory: Fix snapshot_get_branches regression with target_types
    
    When providing target_types parameter, snapshot branches must be sorted when
    iterating otherwise wrong branches can be returned.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/443/ for more details.

Harbormaster completed remote builds in B13586: Diff 12363.Jul 10 2020, 4:12 PM

Update: Sort branches only once

Build is green

Patch application report for D3500 (id=12368)

Rebasing onto 23318c21d1...

Current branch diff-target is up to date.

Changes applied before test

commit 9219a23606c8051377a6f83c07144c4c80ea21e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jul 10 16:02:30 2020 +0200

    in_memory: Fix snapshot_get_branches regression with target_types
    
    When providing target_types parameter, snapshot branches must be sorted when
    iterating otherwise wrong branches can be returned.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/444/ for more details.

Harbormaster completed remote builds in B13590: Diff 12368.Jul 10 2020, 4:23 PM

vlorentz accepted this revision.Jul 10 2020, 4:24 PM

This revision is now accepted and ready to land.Jul 10 2020, 4:24 PM

Closed by commit rDSTO9219a23606c8: in_memory: Fix snapshot_get_branches regression with target_types (authored by anlambert). · Explain WhyJul 10 2020, 4:26 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSTO9219a23606c8: in_memory: Fix snapshot_get_branches regression with target_types.