Differential D3496

Fix branches types in tests
ClosedPublic
Actions

Authored by douardda on Jul 10 2020, 3:50 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDGc895b468ca2e: Fix branches types in tests

Summary

branch names and targets are expected to be bytes.

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jul 10 2020, 3:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 10 2020, 3:50 PM

Build has FAILED

Patch application report for D3496 (id=12359)

Rebasing onto 94d13f79c4...

Current branch diff-target is up to date.

Changes applied before test

commit ea9d9bcc16b58e80b318511051da0b769e8d1d0e
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:49:58 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/39/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/39/console

Harbormaster failed remote builds in B13582: Diff 12359!Jul 10 2020, 3:52 PM

you are ahead of time, new check_snapshot did not yet get released for that.

douardda mentioned this in D3501: Use bytes as snapshot id and get rid of dict manipulation in check_snapshot().Jul 10 2020, 4:50 PM

Build is green

Patch application report for D3496 (id=12359)

Rebasing onto 94d13f79c4...

Current branch diff-target is up to date.

Changes applied before test

commit ea9d9bcc16b58e80b318511051da0b769e8d1d0e
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:49:58 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/40/ for more details.

Harbormaster completed remote builds in B13582: Diff 12359.Jul 15 2020, 2:18 PM

bump dep on swh-loader-core

Build is green

Patch application report for D3496 (id=12406)

Rebasing onto 94d13f79c4...

Current branch diff-target is up to date.

Changes applied before test

commit c895b468ca2e8bf6aa7c502f81f118a55c387ab9
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:49:58 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/41/ for more details.

Harbormaster completed remote builds in B13626: Diff 12406.Jul 15 2020, 3:59 PM

ardumont accepted this revision.Jul 15 2020, 3:59 PM

This revision is now accepted and ready to land.Jul 15 2020, 3:59 PM

Closed by commit rDLDGc895b468ca2e: Fix branches types in tests (authored by douardda). · Explain WhyJul 15 2020, 4:02 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDLDGc895b468ca2e: Fix branches types in tests.