Page MenuHomeSoftware Heritage

Use the new object_metadata_add endpoint instead of origin_metadata_add.
ClosedPublic

Authored by vlorentz on Jul 10 2020, 11:43 AM.

Details

Summary

Note: this changes the authority type from 'deposit_client' to 'deposit',
so we'll have to run a migration on the storage at some point to make
that consistent.

Test Plan

tests will fail until D3456 is merged

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
object_metadata_add
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13761
Build 21087: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 21086: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 10 2020, 11:43 AM
vlorentz edited the test plan for this revision. (Show Details)Jul 10 2020, 11:43 AM

Build has FAILED

Patch application report for D3491 (id=12344)

Rebasing onto ed4e0b38c1...

Current branch diff-target is up to date.
Changes applied before test
commit 10bf08d147443d8071cf5d20e2c56e0e94dc8ed2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 10 11:42:05 2020 +0200

    Use the new object_metadata_add endpoint instead of origin_metadata_add.
    
    Note: this changes the authority type from 'deposit_client' to 'deposit',
    so we'll have to run a migration on the storage at some point to make
    that consistent.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/128/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/128/console

ardumont accepted this revision.Jul 10 2020, 12:02 PM
ardumont added a subscriber: ardumont.

Looks good.

This revision is now accepted and ready to land.Jul 10 2020, 12:02 PM

Build has FAILED

Patch application report for D3491 (id=12538)

Rebasing onto 3442689ecb...

Current branch diff-target is up to date.
Changes applied before test
commit 6400a426824d01661225ced4bf9a0208f42a23a7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 10 11:42:05 2020 +0200

    Use the new object_metadata_add endpoint instead of origin_metadata_add.
    
    Note: this changes the authority type from 'deposit_client' to 'deposit',
    so we'll have to run a migration on the storage at some point to make
    that consistent.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/182/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/182/console

Build is green

Patch application report for D3491 (id=12538)

Rebasing onto 3442689ecb...

Current branch diff-target is up to date.
Changes applied before test
commit 6400a426824d01661225ced4bf9a0208f42a23a7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 10 11:42:05 2020 +0200

    Use the new object_metadata_add endpoint instead of origin_metadata_add.
    
    Note: this changes the authority type from 'deposit_client' to 'deposit',
    so we'll have to run a migration on the storage at some point to make
    that consistent.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/183/ for more details.

ardumont accepted this revision.Jul 20 2020, 11:27 AM