Page MenuHomeSoftware Heritage

Clean up the swh.scheduler / swh.storage pytest plugin imports
ClosedPublic

Authored by olasd on Jul 9 2020, 5:27 PM.

Details

Summary

should help the tests not hang

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jul 9 2020, 5:27 PM

Build is green

Patch application report for D3481 (id=12313)

Rebasing onto 39ffcde657...

Current branch diff-target is up to date.
Changes applied before test
commit ed4e0b38c15b5ac2d559d5ed4ae633f1412b5ae4
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jul 9 17:26:36 2020 +0200

    Clean up the swh.scheduler / swh.storage pytest plugin imports

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/124/ for more details.

ardumont accepted this revision.Jul 9 2020, 5:32 PM
ardumont added a subscriber: ardumont.

Looks good one question about the tox.ini above.

pytest.ini
3

+1 (same for storage D3475)

tox.ini
10

Can't we remove those?

This revision is now accepted and ready to land.Jul 9 2020, 5:32 PM
olasd added inline comments.Jul 9 2020, 5:48 PM
tox.ini
10

Well, that's the way to explicit that we're using the pytest plugins from each of these modules, so I don't think so.