Page MenuHomeSoftware Heritage
Differential D3481

Clean up the swh.scheduler / swh.storage pytest plugin imports
ClosedPublic
Actions

Authored by olasd on Jul 9 2020, 5:27 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDBASEed4e0b38c15b: Clean up the swh.scheduler / swh.storage pytest plugin imports
Summary

should help the tests not hang

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jul 9 2020, 5:27 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 9 2020, 5:27 PM
swh-public-ci added a comment.Jul 9 2020, 5:29 PM

Build is green

Patch application report for D3481 (id=12313)

Rebasing onto 39ffcde657...

Current branch diff-target is up to date.
Changes applied before test
commit ed4e0b38c15b5ac2d559d5ed4ae633f1412b5ae4
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jul 9 17:26:36 2020 +0200

    Clean up the swh.scheduler / swh.storage pytest plugin imports

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/124/ for more details.

Harbormaster completed remote builds in B13534: Diff 12313.Jul 9 2020, 5:29 PM
ardumont accepted this revision.Jul 9 2020, 5:32 PM
ardumont added a subscriber: ardumont.

Looks good one question about the tox.ini above.

pytest.ini
2

+1 (same for storage D3475)

tox.ini
9

Can't we remove those?

This revision is now accepted and ready to land.Jul 9 2020, 5:32 PM
Closed by commit rDLDBASEed4e0b38c15b: Clean up the swh.scheduler / swh.storage pytest plugin imports (authored by olasd). · Explain WhyJul 9 2020, 5:33 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDLDBASEed4e0b38c15b: Clean up the swh.scheduler / swh.storage pytest plugin imports.
olasd mentioned this in D3482: Clean up the swh.scheduler / swh.storage pytest plugin imports.Jul 9 2020, 5:40 PM
olasd added inline comments.Jul 9 2020, 5:48 PM
tox.ini
9

Well, that's the way to explicit that we're using the pytest plugins from each of these modules, so I don't think so.

olasd mentioned this in D3483: Clean up the swh.scheduler / swh.storage pytest plugin imports.Jul 9 2020, 5:56 PM

Revision Contents
Changeset List

PathSize
8 lines
3 lines
2 lines
swh/
loader/
package/
archive/
tests/
6 lines
cran/
tests/
6 lines
debian/
tests/
6 lines
deposit/
tests/
6 lines
nixguix/
tests/
6 lines
npm/
tests/
6 lines
pypi/
tests/
6 lines
3 lines

Diff 12314

View Options

conftest.py

Loading...
View Options

pytest.ini

Loading...
View Options

requirements-test.txt

Loading...
View Options

swh/loader/package/archive/tests/test_tasks.py

Loading...
View Options

swh/loader/package/cran/tests/test_tasks.py

Loading...
View Options

swh/loader/package/debian/tests/test_tasks.py

Loading...
View Options

swh/loader/package/deposit/tests/test_tasks.py

Loading...
View Options

swh/loader/package/nixguix/tests/test_tasks.py

Loading...
View Options

swh/loader/package/npm/tests/test_tasks.py

Loading...
View Options

swh/loader/package/pypi/tests/test_tasks.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal