Page MenuHomeSoftware Heritage

Migrate to new swhid naming
ClosedPublic

Authored by ardumont on Jul 8 2020, 10:11 AM.

Details

Summary

It is deprecated since model 0.3.8.

Related to D3419

Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3455 (id=12231)

Rebasing onto c586ff1740...

Current branch diff-target is up to date.
Changes applied before test
commit 724100409e02940bcdfd29cfe120a812388d50ee
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 8 10:08:20 2020 +0200

    Migrate to new swhid naming
    
    It is deprecated since model 0.3.8.
    
    Related to D3419

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/41/ for more details.

swh/deposit/migrations/0018_migrate_swhids.py
325

That's a migration script so, pffffiou nothing to do ;)

Wondering how to exclude those from the coverage now though.

swh/deposit/migrations/0018_migrate_swhids.py
325

IMO migration scripts should be tested too

This revision is now accepted and ready to land.Jul 8 2020, 11:10 AM
swh/deposit/migrations/0018_migrate_swhids.py
325

ok then, but from now on ;)
It's been deployed already.

Although, wait this one got tested!

swh/deposit/migrations/0018_migrate_swhids.py
325

Although, wait this one got tested!

Nope, it did not in the end ¯\_(ツ)_/¯...
It got battle tested on staging "only" (quite exhaustively).

But yeah, ok, will do the necessary work in the future ;)

[1] D3153

This revision was automatically updated to reflect the committed changes.