Fix import errors after swh-model update and move from PIDs to SWHIDs
ClosedPublic
Actions

Authored by anlambert on Jul 3 2020, 4:11 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDTSCNef83cf24893d: Fix import errors after swh-model update and move from PIDs to SWHIDs

Summary

Some functions in swh.model.cli imported by swh-scanner were renamed in
swh-model 0.3.8 leading to import errors, fix those.

Also rename references to persistent identifiers (doc, variables, function
names) in order to use the SWHID abbreviation as this is what should be
used now.

Diff Detail

Repository

rDTSCN Code scanner

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 3 2020, 4:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2020, 4:11 PM

ardumont accepted this revision.Jul 3 2020, 4:14 PM

This revision is now accepted and ready to land.Jul 3 2020, 4:14 PM

Build is green

Patch application report for D3415 (id=12109)

Rebasing onto 0f10ec6ae8...

Current branch diff-target is up to date.

Changes applied before test

commit ef83cf24893d92a019e3626df251fc40b149eb9d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jul 3 15:57:53 2020 +0200

    Fix import errors after swh-model update and move from PIDs to SWHIDs
    
    Some functions in swh.model.cli imported by swh-scanner were renamed in
    swh-model 0.3.8 leading to import errors, fix those.
    
    Also rename references to persistent identifiers (doc, variables, function
    names) in order to use the SWHID abbreviation as this is what should be
    used now.

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/35/ for more details.

Harbormaster completed remote builds in B13330: Diff 12109.Jul 3 2020, 4:14 PM

Closed by commit rDTSCNef83cf24893d: Fix import errors after swh-model update and move from PIDs to SWHIDs (authored by anlambert). · Explain WhyJul 3 2020, 4:15 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDTSCNef83cf24893d: Fix import errors after swh-model update and move from PIDs to SWHIDs.

DanSeraf added a subscriber: DanSeraf.Jul 3 2020, 4:25 PM

DanSeraf removed a subscriber: DanSeraf.Jul 3 2020, 4:30 PM