Differential D3410

tests: Refactor repository with tampered information scenario
ClosedPublic
Actions

Authored by ardumont on Jul 3 2020, 1:55 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2462: svn loader: Refactor tests using pytest fixtures

Commits

rDLDSVN01f9382e7442: tests: Refactor repository with tampered information scenario

Summary

This actually uses a real modified repository.

Prior to this, this faked the alteration by modifying the input of the loader
which is a hack.

Related to T2462
Related to P713
Related to D3208

Test Plan

tox

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13314
Build 20343: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20342: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 3 2020, 1:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2020, 1:55 PM

Build is green

Patch application report for D3410 (id=12093)

Rebasing onto 4cb4b0301e...

Current branch diff-target is up to date.

Changes applied before test

commit 01f9382e7442ef6510d016b7f7f42d6ac4c04b22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:52:16 2020 +0200

    tests: Refactor repository with tampered information scenario
    
    This actually uses a real modified repository.
    
    Prior to this, this faked the alteration by modifying the input of the loader
    which is a hack.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/60/ for more details.

Harbormaster completed remote builds in B13314: Diff 12093.Jul 3 2020, 1:56 PM