Differential D3393

loader.svn: Reuse swh.model.from_disk.iter_directory function
ClosedPublic
Actions

Authored by ardumont on Jul 2 2020, 12:08 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLDSVNee23fd758227: Reuse swh.model.from_disk.iter_directory function

Summary

Depends D3391 (model)

Test Plan

tox

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13256
Build 20245: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20244: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 2 2020, 12:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 2 2020, 12:08 PM

Build has FAILED

Patch application report for D3393 (id=12036)

Rebasing onto b268749fda...

Current branch diff-target is up to date.

Changes applied before test

commit ee23fd758227a053df267f895037d5d437d360a1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 12:08:38 2020 +0200

    Reuse swh.model.from_disk.iter_directory function

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/30/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/30/console

Harbormaster failed remote builds in B13256: Diff 12036!Jul 2 2020, 12:09 PM

ardumont mentioned this in D3390: Unify object_type some more within the merkle and from_disk modules.Jul 2 2020, 12:12 PM

anlambert accepted this revision.Jul 2 2020, 2:45 PM

This revision is now accepted and ready to land.Jul 2 2020, 2:45 PM

Build is green

Patch application report for D3393 (id=12036)

Rebasing onto b268749fda...

Current branch diff-target is up to date.

Changes applied before test

commit ee23fd758227a053df267f895037d5d437d360a1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 12:08:38 2020 +0200

    Reuse swh.model.from_disk.iter_directory function

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/31/ for more details.

Harbormaster completed remote builds in B13256: Diff 12036.Jul 2 2020, 3:21 PM

Closed by commit rDLDSVNee23fd758227: Reuse swh.model.from_disk.iter_directory function (authored by ardumont). · Explain WhyJul 2 2020, 3:22 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVNee23fd758227: Reuse swh.model.from_disk.iter_directory function.

ardumont edited the test plan for this revision. (Show Details)Jul 2 2020, 3:23 PM