Differential D3360

replayer: Drop obsolete fields from origin-visit
ClosedPublic
Actions

Authored by ardumont on Jun 26 2020, 9:58 AM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2310: Make origin visits immutable

Commits

rDSTO86205198911c: replayer: Drop obsolete fields from origin-visit

Summary

Otherwise, we won't be able to replay them (since the storage no
longer knows what those obsolete keys are).

Related to T2310

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

replay-drop-optional-fields

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13128
Build 20031: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20030: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 26 2020, 9:58 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 26 2020, 9:58 AM

ardumont mentioned this in T2310: Make origin visits immutable.Jun 26 2020, 10:00 AM

Build is green

Patch application report for D3360 (id=11913)

Rebasing onto b991e69707...

Current branch diff-target is up to date.

Changes applied before test

commit 86205198911c12afcdbec14ea9e8b905f5e190a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 26 09:47:01 2020 +0200

    replayer: Drop obsolete fields from origin-visit
    
    Otherwise, we won't be able to replay them.
    
    Related T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/367/ for more details.

Harbormaster completed remote builds in B13128: Diff 11913.Jun 26 2020, 10:05 AM

douardda accepted this revision.Jun 26 2020, 10:16 AM

This revision is now accepted and ready to land.Jun 26 2020, 10:16 AM

Closed by commit rDSTO86205198911c: replayer: Drop obsolete fields from origin-visit (authored by ardumont). · Explain WhyJun 26 2020, 10:23 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO86205198911c: replayer: Drop obsolete fields from origin-visit.