Page MenuHomeSoftware Heritage

templates/origin-save: Add a new "Info" column in save requests table
ClosedPublic

Authored by anlambert on Thu, Jun 25, 6:27 PM.

Details

Summary

An "Info" button has been added in that new column. When clicking on it, a
popover containing various loading task information will be displayed.

For anonymous users, the displayed info are:

  • Task type
  • Task arguments
  • Task scheduling date
  • Task start date
  • Task termination date
  • Task duration
  • Task log (with Traceback removed in case of failed task, only the exception is displayed)

For staff users, more internal info and a full Traceback are displayed in
case of a failed task.

Below are some screenshots of the result:

Related to T2325

Depends on D3354.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Thu, Jun 25, 6:27 PM

Build is green

Patch application report for D3358 (id=11909)

Could not rebase; Attempt merge onto 608f13c1cb...

Updating 608f13c1..90cb526c
Fast-forward
 cypress/fixtures/save-task-info.json            |  16 +++
 cypress/integration/origin-save.spec.js         |  74 +++++++----
 swh/web/admin/origin_save.py                    |  14 --
 swh/web/assets/src/bundles/admin/origin-save.js |  92 +------------
 swh/web/assets/src/bundles/save/index.js        | 118 +++++++++++++++++
 swh/web/common/origin_save.py                   |  68 ++++++----
 swh/web/misc/origin_save.py                     |  16 +++
 swh/web/templates/misc/origin-save.html         |   1 +
 swh/web/tests/common/test_origin_save.py        | 166 +++++++++++++++++++-----
 9 files changed, 376 insertions(+), 189 deletions(-)
 create mode 100644 cypress/fixtures/save-task-info.json
Changes applied before test
commit 90cb526c3baffa018510814c79d01669f5711cfe
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 25 14:34:28 2020 +0200

    templates/origin-save: Add a new "Info" column in save requests table
    
    An "Info" button has been added in that new column. When clicking on it, a
    popover containing various loading task information will be displayed.
    
    For anonymous users, the displayed info are:
    
      - Task type
      - Task arguments
      - Task scheduling date
      - Task start date
      - Task termination date
      - Task duration
      - Task log (with Traceback removed in case of failed task,
        only the exception is displayed)
    
    For staff users, more internal info and a full Traceback are displayed in
    case of a failed task.
    
    Related to T2325

commit 5d9995f3beb2a03621f76b304ffecdd915bdfbb2
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 25 14:52:50 2020 +0200

    common/origin_save: Speedup save requests list loading
    
    When loading save requests list, the web application will try to find
    a visit date for each submitted origin save request. This process is
    repeated while a visit date has not been found yet.
    
    To speedup the loading of the requests lst, stop trying to find a visit
    date one month after a save request submission as those requests to storage
    are expensive and associated loading task surely ended up with errors.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/228/ for more details.

anlambert updated this revision to Diff 11919.Fri, Jun 26, 11:37 AM

Update:

  • Rebase
  • Improve popover display
    • Add a close button in popover header
anlambert updated this revision to Diff 11920.Fri, Jun 26, 11:42 AM

Remove file committed by mistake

Build is green

Patch application report for D3358 (id=11919)

Rebasing onto 04170796f4...

Current branch diff-target is up to date.
Changes applied before test
commit 556bf657601a04e2f65f0663334ea98811510c04
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 25 14:34:28 2020 +0200

    templates/origin-save: Add a new "Info" column in save requests table
    
    An "Info" button has been added in that new column. When clicking on it, a
    popover containing various loading task information will be displayed.
    
    For anonymous users, the displayed info are:
    
      - Task type
      - Task arguments
      - Task scheduling date
      - Task start date
      - Task termination date
      - Task duration
      - Task log (with Traceback removed in case of failed task,
        only the exception is displayed)
    
    For staff users, more internal info and a full traceback are displayed in
    case of a failed task.
    
    Related to T2325

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/230/ for more details.

Build is green

Patch application report for D3358 (id=11920)

Rebasing onto 04170796f4...

Current branch diff-target is up to date.
Changes applied before test
commit c0983d0ea516ab0dfb7c99bf126263b46f7c90e0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 25 14:34:28 2020 +0200

    templates/origin-save: Add a new "Info" column in save requests table
    
    An "Info" button has been added in that new column. When clicking on it, a
    popover containing various loading task information will be displayed.
    
    For anonymous users, the displayed info are:
    
      - Task type
      - Task arguments
      - Task scheduling date
      - Task start date
      - Task termination date
      - Task duration
      - Task log (with Traceback removed in case of failed task,
        only the exception is displayed)
    
    For staff users, more internal info and a full traceback are displayed in
    case of a failed task.
    
    Related to T2325

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/231/ for more details.

ardumont accepted this revision.Mon, Jun 29, 10:37 AM
This revision is now accepted and ready to land.Mon, Jun 29, 10:37 AM