Page MenuHomeSoftware Heritage

common/identifiers: Fix missing lines qualifier processing in resolver
ClosedPublic

Authored by anlambert on Jun 25 2020, 12:37 PM.

Details

Summary

When a content object is anchored to a revision, the resolved url from the
associated SWHID will target the revision view instead of the content one.

So ensure the SWHID lines qualifier is also processed in that case in order
for the "scroll to lines" feature to work each time a content is displayed
in a view.

Closes T2464

Diff Detail

Repository
rDWAPPS Web applications
Branch
swhid-resolve-fix-lines-context
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13105
Build 19992: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 19991: arc lint + arc unit

Event Timeline

anlambert created this revision.Jun 25 2020, 12:37 PM

Build is green

Patch application report for D3352 (id=11889)

Rebasing onto e5f80ec6c2...

Current branch diff-target is up to date.
Changes applied before test
commit 28e4ee3a1c691f4067acc18644174a5bc809dd49
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 25 12:34:40 2020 +0200

    common/identifiers: Process lines qualifier regardless of object type
    
    When a content object is anchored to a revision, the resolved url from the
    associated SWHID will target the revision view instead of the content one.
    
    So ensure the SWHID lines qualifier is processed for each type of object type
    in order for the "scroll to lines" feature to work each time a content is
    displayed in a view.
    
    Closes T2464

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/224/ for more details.

anlambert updated this revision to Diff 11891.Jun 25 2020, 1:57 PM

Update: Process lines qualifier only when needed

anlambert edited the summary of this revision. (Show Details)Jun 25 2020, 1:57 PM
anlambert retitled this revision from common/identifiers: Process lines qualifier regardless of object type to common/identifiers: Fix missing lines qualifier processing in resolver.

Build is green

Patch application report for D3352 (id=11891)

Rebasing onto e5f80ec6c2...

Current branch diff-target is up to date.
Changes applied before test
commit 608f13c1cbed490c450e2bde5a8be108b333329b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 25 12:34:40 2020 +0200

    common/identifiers: Fix missing lines qualifier processing in resolver
    
    When a content object is anchored to a revision, the resolved url from the
    associated SWHID will target the revision view instead of the content one.
    
    So ensure the SWHID lines qualifier is also processed in that case in order
    for the "scroll to lines" feature to work each time a content is displayed
    in a view.
    
    Closes T2464

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/225/ for more details.

ardumont accepted this revision.Jun 25 2020, 2:40 PM
This revision is now accepted and ready to land.Jun 25 2020, 2:40 PM
anlambert edited the summary of this revision. (Show Details)Jun 25 2020, 2:46 PM