Differential D3341

OriginVisitStatus: Allow "created" status
ClosedPublic
Actions

Authored by ardumont on Jun 24 2020, 9:14 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2310: Make origin visits immutable

Commits

rDMOD661b7c2c76bb: OriginVisitStatus: Allow "created" status

Summary

First status when an origin-visit is created.
We create an origin-visit-status alongside with that status.

The db model allows it already, not the model yet. This is just realigning that
missing part. The adaptation is incoming storage wise.

Related to T2310

Test Plan

tox

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13065
Build 19922: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19921: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 24 2020, 9:14 AM

Build is green

Patch application report for D3341 (id=11849)

Could not rebase; Attempt merge onto f349bdc628...

Updating f349bdc..57e0cbe
Fast-forward
 swh/model/hypothesis_strategies.py |  4 ++--
 swh/model/model.py                 | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

Changes applied before test

commit 57e0cbedb61c4572bcb1bb4acbf58153e456a419
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 24 09:13:01 2020 +0200

    OriginVisitStatus: Allow "created" status
    
    Related to T2310

commit 636f8c2aa40419045908a537a647d22fc368533c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jun 23 17:29:53 2020 +0200

    model.OriginVisit: Make obsolete fields optional
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/78/ for more details.

Harbormaster completed remote builds in B13064: Diff 11849.Jun 24 2020, 9:15 AM

Update hypothesis strategy with that new status as well

Build is green

Patch application report for D3341 (id=11850)

Could not rebase; Attempt merge onto f349bdc628...

Updating f349bdc..661b7c2
Fast-forward
 swh/model/hypothesis_strategies.py |  6 +++---
 swh/model/model.py                 | 14 +++++++-------
 2 files changed, 10 insertions(+), 10 deletions(-)

Changes applied before test

commit 661b7c2c76bbd74433ad10427fb2e9875d755a16
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 24 09:13:01 2020 +0200

    OriginVisitStatus: Allow "created" status
    
    Related to T2310

commit 636f8c2aa40419045908a537a647d22fc368533c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jun 23 17:29:53 2020 +0200

    model.OriginVisit: Make obsolete fields optional
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/79/ for more details.

Harbormaster completed remote builds in B13065: Diff 11850.Jun 24 2020, 9:17 AM

vlorentz accepted this revision.Jun 24 2020, 10:12 AM

This revision is now accepted and ready to land.Jun 24 2020, 10:12 AM

Closed by commit rDMOD661b7c2c76bb: OriginVisitStatus: Allow "created" status (authored by ardumont). · Explain WhyJun 24 2020, 10:42 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDMOD661b7c2c76bb: OriginVisitStatus: Allow "created" status.