Page MenuHomeSoftware Heritage

tests/common/test_identifiers: Prevent flaky test
ClosedPublic

Authored by anlambert on Jun 23 2020, 5:14 PM.

Details

Summary

There is no guarantee that the directory_with_subdirs strategy will return
a directory with subdirs containing files.

See this failed build for instance.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13062
Build 19916: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 19915: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3339 (id=11847)

Rebasing onto c18cd1a877...

Current branch diff-target is up to date.
Changes applied before test
commit 358699c4d0af957e504fa098d4e5da05b45ca5df
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 23 17:12:52 2020 +0200

    tests/common/test_identifiers: Prevent flaky test
    
    There is no guarantee that the directory_with_subdirs strategy will return
    a directory with subdirs containing files.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/215/ for more details.

This revision is now accepted and ready to land.Jun 24 2020, 1:43 PM

Build is green

Patch application report for D3339 (id=11860)

Rebasing onto e8f3588ede...

Current branch diff-target is up to date.
Changes applied before test
commit 25abbb1cfdbd437e6758b92fad03d553752908f7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 23 17:12:52 2020 +0200

    tests/common/test_identifiers: Prevent flaky test
    
    There is no guarantee that the directory_with_subdirs strategy will return
    a directory with subdirs containing files.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/218/ for more details.