test_identifiers: Prevent flaky test
ClosedPublic
Actions

Authored by anlambert on Jun 23 2020, 5:14 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS25abbb1cfdbd: tests/common/test_identifiers: Prevent flaky test

Summary

There is no guarantee that the directory_with_subdirs strategy will return
a directory with subdirs containing files.

See this failed build for instance.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 23 2020, 5:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 23 2020, 5:14 PM

Build is green

Patch application report for D3339 (id=11847)

Rebasing onto c18cd1a877...

Current branch diff-target is up to date.

Changes applied before test

commit 358699c4d0af957e504fa098d4e5da05b45ca5df
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 23 17:12:52 2020 +0200

    tests/common/test_identifiers: Prevent flaky test
    
    There is no guarantee that the directory_with_subdirs strategy will return
    a directory with subdirs containing files.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/215/ for more details.

Harbormaster completed remote builds in B13062: Diff 11847.Jun 23 2020, 5:23 PM

ardumont accepted this revision.Jun 24 2020, 1:43 PM

This revision is now accepted and ready to land.Jun 24 2020, 1:43 PM

Rebase

Build is green

Patch application report for D3339 (id=11860)

Rebasing onto e8f3588ede...

Current branch diff-target is up to date.

Changes applied before test

commit 25abbb1cfdbd437e6758b92fad03d553752908f7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 23 17:12:52 2020 +0200

    tests/common/test_identifiers: Prevent flaky test
    
    There is no guarantee that the directory_with_subdirs strategy will return
    a directory with subdirs containing files.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/218/ for more details.

Harbormaster completed remote builds in B13075: Diff 11860.Jun 24 2020, 2:36 PM

Closed by commit rDWAPPS25abbb1cfdbd: tests/common/test_identifiers: Prevent flaky test (authored by anlambert). · Explain WhyJun 24 2020, 2:59 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS25abbb1cfdbd: tests/common/test_identifiers: Prevent flaky test.