templates/layout: Hide full width switch on small screens
ClosedPublic
Actions

Authored by anlambert on Jun 22 2020, 2:29 PM.

Details

Reviewers

vlorentz
ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2461: "Full width" button has no effect with some "small" screens widths

Commits

rDWAPPS9e0b50ba24f8: templates/layout: Hide full width switch on small screens

Summary

That feature is only useful for large screens so hide the full width
switch on screens where width is lesser than 992px.

Closes T2461

Diff Detail

Repository

rDWAPPS Web applications

Branch

full-width-switch-large-screens-only

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13006
Build 19822: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19821: arc lint + arc unit

Event Timeline

anlambert created this revision.Jun 22 2020, 2:29 PM

Build is green

Patch application report for D3332 (id=11794)

Rebasing onto dc860b2a38...

Current branch diff-target is up to date.

Changes applied before test

commit 9e0b50ba24f8d6bbf8e15ca904cfc6f31f2b8c4a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jun 22 14:24:29 2020 +0200

    templates/layout: Hide full width switch on small screens
    
    That feature is only useful for large screens so hide the full width
    switch on screens where width is lesser than 992px.
    
    Closes T2461

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/211/ for more details.

Harbormaster completed remote builds in B13006: Diff 11794.Jun 22 2020, 2:40 PM

ardumont accepted this revision.Jun 22 2020, 2:42 PM

This revision is now accepted and ready to land.Jun 22 2020, 2:42 PM

Closed by commit rDWAPPS9e0b50ba24f8: templates/layout: Hide full width switch on small screens (authored by anlambert). · Explain WhyJun 22 2020, 5:21 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS9e0b50ba24f8: templates/layout: Hide full width switch on small screens.