Fixes [1]
(production webapp is patched manually for now)
[1] https://sentry.softwareheritage.org/share/issue/9848d9ea23d94d6ba8855bc7a7d7d297/
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDSTO32fded1c9bc7: algos.snapshot: Fix edge case when snapshot is not resolved
tox
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12979 Build 19780: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 19779: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3322 (id=11769)
Rebasing onto 9514a1db60...
First, rewinding head to replay your work on top of it... Applying: algos.snapshot: Fix edge case when snapshot is not resolved
Changes applied before test
commit 950ea8abe0d5aab5630a8895a0b725f19126ed36
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jun 19 18:50:18 2020 +0200
algos.snapshot: Fix edge case when snapshot is not resolved
Fixes [1]
[1] https://sentry.softwareheritage.org/share/issue/9848d9ea23d94d6ba8855bc7a7d7d297/See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/317/ for more details.
Comment Actions
Yes indeed, missing a test.
I just wanted to make it appear soon on friday evening ;)
Comment Actions
Build is green
Patch application report for D3322 (id=11779)
Rebasing onto 9514a1db60...
Current branch diff-target is up to date.
Changes applied before test
commit 753addf35db530ce7a12a03e24c6b8cc4e040396
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jun 19 18:50:18 2020 +0200
algos.snapshot: Fix edge case when snapshot is not resolved
Fixes [1]
[1] https://sentry.softwareheritage.org/share/issue/9848d9ea23d94d6ba8855bc7a7d7d297/See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/320/ for more details.
Comment Actions
- Rebase
- also adapt to avoid using origin-visit-add's returned reference since that will change [1]
[1] D3326
Comment Actions
Build is green
Patch application report for D3322 (id=11784)
Rebasing onto 53c4392acc...
Current branch diff-target is up to date.
Changes applied before test
commit 32fded1c9bc77a9431f8c147d4b76d86b3ba65f7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jun 19 18:50:18 2020 +0200
algos.snapshot: Fix edge case when snapshot is not resolved
Fixes [1]
[1] https://sentry.softwareheritage.org/share/issue/9848d9ea23d94d6ba8855bc7a7d7d297/See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/322/ for more details.