Paths

Table of Contentst

Differential D3321

Add helper function to ensure loader visit/visit-status are as expected
ClosedPublic
Actions

Authored by ardumont on Jun 19 2020, 5:54 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDLDBASEf4ebf5c3ac3b: Add helper function to ensure loader visit are as expected

Summary

This bootstraps a new swh.loader.tests.common module to declare common helper
functions we can reuse for all loaders.

(I wonder if putting this directly in swh/loader/tests/__init__.py is not
enough?)

Following a discussion with @olasd, i preferred to open a new diff to decrease the
size of the original one [1]

[1] Related to D3305#inline-22935

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12973
Build 19769: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19768: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 19 2020, 5:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 19 2020, 5:54 PM

ardumont mentioned this in D3305: package.loader: Retrieve latest snapshot out of the latest visit status.Jun 19 2020, 5:56 PM

Build is green

Patch application report for D3321 (id=11763)

Rebasing onto e7e27a16cd...

Current branch diff-target is up to date.

Changes applied before test

commit 2b7209f921de49752543d07b06bb3b84afaac6c9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 19 17:50:36 2020 +0200

    Add helper function to ensure loader visit are as expected
    
    This bootstraps a swh.loader.tests.common module

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/74/ for more details.

Harbormaster completed remote builds in B12973: Diff 11763.Jun 19 2020, 5:56 PM

ardumont added a child revision: D3305: package.loader: Retrieve latest snapshot out of the latest visit status.Jun 19 2020, 5:57 PM

ardumont edited the summary of this revision. (Show Details)

olasd accepted this revision.Jun 19 2020, 6:11 PM

This revision is now accepted and ready to land.Jun 19 2020, 6:11 PM

olasd removed a reviewer: olasd.Jun 19 2020, 6:12 PM

This revision now requires review to proceed.Jun 19 2020, 6:12 PM

olasd removed a reviewer: Reviewers.Jun 19 2020, 6:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 19 2020, 6:12 PM

olasd requested changes to this revision.Jun 19 2020, 6:21 PM

olasd added inline comments.

swh/loader/tests/common.py
1	lies! ;)
12	`assert_last_visit_matches` would be more descriptive, I believe.
29	`Check that the returned visit has the given type`
30	`Check that the visit status points to the given snapshot`
34	if... ?
41–42	Should probably just be an assert too? e.g. `assert visit_and_status, f"origin {url} has no visits?"`
45	s/with/has/
48	s/with/has/
52	s/with/points to/

This revision now requires changes to proceed.Jun 19 2020, 6:21 PM

Adapt according to review

Build is green

Patch application report for D3321 (id=11767)

Rebasing onto e7e27a16cd...

Current branch diff-target is up to date.

Changes applied before test

commit f4ebf5c3ac3b5c203e744184ae1434baa018a350
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 19 17:50:36 2020 +0200

    Add helper function to ensure loader visit are as expected
    
    This bootstraps a swh.loader.tests.common module

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/77/ for more details.

Harbormaster completed remote builds in B12977: Diff 11767.Jun 19 2020, 6:47 PM

Thanks for all the good suggestions, fixed!

Cheers,

olasd accepted this revision.Jun 22 2020, 10:15 AM

This revision is now accepted and ready to land.Jun 22 2020, 10:15 AM

Closed by commit rDLDBASEf4ebf5c3ac3b: Add helper function to ensure loader visit are as expected (authored by ardumont). · Explain WhyJun 22 2020, 10:19 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEf4ebf5c3ac3b: Add helper function to ensure loader visit are as expected.