Page MenuHomeSoftware Heritage

loader: Read snapshot out of the last visit status
ClosedPublic

Authored by ardumont on Jun 17 2020, 5:30 PM.

Details

Summary

Preparatory work to drop unused fields from OriginVisit

Related to T2310

Diff Detail

Repository
rDLDG Git loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13025
Build 19854: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 19853: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3308 (id=11714)

Rebasing onto 10376d5da4...

Current branch diff-target is up to date.
Changes applied before test
commit 223d53b96c9a65c78463b1168c2fcde6a98a086c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 17 17:29:53 2020 +0200

    loader: Read snapshot out of the last visit status
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/21/ for more details.

Drop duplication
(Tests will fail as a new release is needed for the loader-core)

Build has FAILED

Patch application report for D3308 (id=11770)

Rebasing onto 10376d5da4...

Current branch diff-target is up to date.
Changes applied before test
commit 046e1d5681c2acf16d99f8ae1e85740425a915d9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 17 17:29:53 2020 +0200

    loader: Read snapshot out of the last visit status
    
    Related to T2310

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/22/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/22/console

Simplify diff to use swh.storage.algos.snapshot.snapshot-get-latest
function

Add missing requirements change

Build is green

Patch application report for D3308 (id=11810)

Rebasing onto 473a615a96...

Current branch diff-target is up to date.
Changes applied before test
commit 169acd0802405a5979bd55b69ae17576231c0f1e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 22 16:30:08 2020 +0200

    loader: Retrieve latest snapshot with snapshot-get-latest function
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/23/ for more details.

Build is green

Patch application report for D3308 (id=11811)

Rebasing onto 473a615a96...

Current branch diff-target is up to date.
Changes applied before test
commit 132217e2eb24236e3bc25a9fd2e1e124782fa188
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 22 16:30:08 2020 +0200

    loader: Retrieve latest snapshot with snapshot-get-latest function
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/24/ for more details.

swh/loader/git/loader.py
213

hmmm, wondering if that should not go directly in swh.loader.core.loader then...
That way, remaining dvcs loaders (svn, git, hg) have access to it directly...
get-last-snapshot or something

ardumont added inline comments.
swh/loader/git/from_disk.py
143

From discussion with @olasd and @douardda, that could be reworked this to origin_get_latest_visit_status instead.

Use origin-get-latest-visit-status in from_disk loader

We don't need to retrieve the snapshot object so directly retrieve its
reference.

Build is green

Patch application report for D3308 (id=11826)

Rebasing onto 473a615a96...

Current branch diff-target is up to date.
Changes applied before test
commit c901e60b024632aaa6750cd7df6f93bb9a9aa770
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 22 16:30:08 2020 +0200

    loader: Retrieve latest snapshot information
    
    using latest snapshot-get-latest and origin-get-latest-visit-status functions
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/25/ for more details.

Drop unnecessary moved instruction

swh/loader/git/from_disk.py
143

done

Build is green

Patch application report for D3308 (id=11828)

Rebasing onto 473a615a96...

Current branch diff-target is up to date.
Changes applied before test
commit 55ff84b1a6fe7e83844ad0f8b1375ea1c2a983ea
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 22 16:30:08 2020 +0200

    loader: Read snapshot out of the last origin visit status
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/26/ for more details.

This revision is now accepted and ready to land.Jun 23 2020, 2:30 PM