This lets us keep the tests a little DRYer.
Depends on D3287.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDSCHe0fa5c58d38c: Move lister addition in scheduler tests to a pytest fixture
tox tests changed to use the new fixture
Diff Detail
Diff Detail
- Repository
- rDSCH Scheduling utilities
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3288 (id=11661)
Could not rebase; Attempt merge onto 1c93e553a1...
Updating 1c93e55..e0fa5c5 Fast-forward swh/scheduler/model.py | 51 +++++++++++++++++++++++++++++------ swh/scheduler/tests/conftest.py | 8 ++++++ swh/scheduler/tests/test_model.py | 19 ++++++++++++- swh/scheduler/tests/test_scheduler.py | 14 ++++------ 4 files changed, 74 insertions(+), 18 deletions(-)
Changes applied before test
commit e0fa5c58d38c2cbe39fe1f8e0fbb36591c29b661
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Tue Jun 16 10:24:03 2020 +0200
Move lister addition in scheduler tests to a pytest fixture
This lets us keep the tests a little DRYer.
commit 04894bd7fb6a1c4d658587395cbbe4f2d60c2a2a
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Tue Jun 16 10:22:23 2020 +0200
Lister.instance_name doesn't need a factory/default value
commit f520108a8d0abefec3a91967aedbc29fb1a808f8
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Tue Jun 16 10:08:59 2020 +0200
Improve support of primary keys
This splits primary keys across "automatic" primary keys (handled by the
database) and manual primary keys (managed by the user). Use the opportunity to
improve/clarify the documentation of field metadata attributes.See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/30/ for more details.