Page MenuHomeSoftware Heritage

scanner: retrieve file attributes
ClosedPublic

Authored by DanSeraf on Jun 15 2020, 6:35 PM.

Details

Summary

model: get file attributes from a specific directory

Diff Detail

Repository
rDTSCN Code scanner
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

DanSeraf created this revision.Jun 15 2020, 6:35 PM

Build is green

Patch application report for D3284 (id=11653)

Rebasing onto 13ac68a947...

Current branch diff-target is up to date.
Changes applied before test
commit 5f2ee199a48249b1bd4a3a7b9a6b444980afbe77
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Mon Jun 15 18:33:16 2020 +0200

    model: get file attributes from a specific directory

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/27/ for more details.

vlorentz added inline comments.
swh/scanner/model.py
195

endswith??

DanSeraf added inline comments.Jun 16 2020, 12:15 PM
swh/scanner/model.py
195

oh... I missed that.

DanSeraf updated this revision to Diff 11663.Jun 16 2020, 12:15 PM

wrong directory check

Build is green

Patch application report for D3284 (id=11663)

Rebasing onto 13ac68a947...

Current branch diff-target is up to date.
Changes applied before test
commit e3193e3128d6cc81e08b5202658519a8d38b1709
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Mon Jun 15 18:33:16 2020 +0200

    model: get file attributes from a specific directory

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/28/ for more details.

DanSeraf updated this revision to Diff 11666.Jun 16 2020, 1:10 PM
  • wrong check when using the source path

Build is green

Patch application report for D3284 (id=11666)

Rebasing onto 13ac68a947...

Current branch diff-target is up to date.
Changes applied before test
commit bf9e586436d88ba446b94004311b6d2623a10215
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Mon Jun 15 18:33:16 2020 +0200

    model: get file attributes from a specific directory

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/29/ for more details.

vlorentz accepted this revision.Jun 16 2020, 5:13 PM
This revision is now accepted and ready to land.Jun 16 2020, 5:13 PM
This revision was automatically updated to reflect the committed changes.