Differential D3277

Start migrating the validate proxy toward using BaseModel objects
ClosedPublic
Actions

Authored by ardumont on Jun 13 2020, 8:41 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTO874da2dee195: Start migrating the validate proxy toward using BaseModel objects

Summary

This will allow to progress incrementally towards removing it.

When it allows to use BaseModel objects everywhere (and tests in test_storage
are adapted to use this property), it will be time to remove it entirely (as
it's only used in test).

It's preparatory work for future diffs.

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

in-mem-orig-visit-status-add-idempotent

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 12826
Build 19522: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19521: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 13 2020, 8:41 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 13 2020, 8:41 AM

ardumont added a child revision: D3278: in_memory: Make origin-visit-status-add respect "on conflict ignore" policy.Jun 13 2020, 8:42 AM

Build is green

Patch application report for D3277 (id=11619)

Rebasing onto 33efdb0dd4...

Current branch diff-target is up to date.

Changes applied before test

commit 874da2dee1957ac5e9f5b17a81e11d9d9e8690f0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Jun 13 08:37:57 2020 +0200

    Start migrating the validate proxy toward using BaseModel objects
    
    This will allow to progress incrementally towards removing it.
    
    When it allows to use BaseModel objects everywhere (and tests in test_storage
    are adapted to use this property), it will be time to remove it entirely (as
    it's only used in test).
    
    It's preparatory work for future diffs.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/268/ for more details.

Harbormaster completed remote builds in B12826: Diff 11619.Jun 13 2020, 8:49 AM

ardumont added a child revision: D3279: test_storage: Add journal behavior coverage for origin-visit-*add.Jun 15 2020, 11:28 AM

vlorentz accepted this revision.Jun 15 2020, 12:09 PM

This revision is now accepted and ready to land.Jun 15 2020, 12:09 PM

Closed by commit rDSTO874da2dee195: Start migrating the validate proxy toward using BaseModel objects (authored by ardumont). · Explain WhyJun 15 2020, 12:18 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO874da2dee195: Start migrating the validate proxy toward using BaseModel objects.

ardumont mentioned this in D3296: storage*: Add origin-visit-status-get-latest endpoint.Jun 17 2020, 9:26 AM

ardumont mentioned this in D3298: validate.snapshot_add: Make it able to deal directly with Snapshot.Jun 17 2020, 9:36 AM