Page MenuHomeSoftware Heritage

Use the automatic RPC client/server generation
ClosedPublic

Authored by olasd on Jun 10 2020, 4:10 PM.

Details

Summary

Red diffs are good diffs.

Test Plan

tox

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
feature/automatic-rpc
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12761
Build 19411: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 19410: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3257 (id=11548)

Rebasing onto aedd323f1e...

Current branch diff-target is up to date.
Changes applied before test
commit b55b1a545b56356cfec85ca4d78192876b981bec
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 10 16:09:53 2020 +0200

    Use the automatic RPC client/server generation

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/15/ for more details.

This revision is now accepted and ready to land.Jun 10 2020, 4:15 PM

Make sure the global variable for the api server is defined

Build is green

Patch application report for D3257 (id=11557)

Rebasing onto aedd323f1e...

Current branch diff-target is up to date.
Changes applied before test
commit 3a750179198cc3c98b81736cc9fe3bb78c278b3d
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 10 16:09:53 2020 +0200

    Use the automatic RPC client/server generation

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/16/ for more details.

besides I don't like the _scheduler global var name, LGTM

Rename the global var to scheduler

Build is green

Patch application report for D3257 (id=11562)

Rebasing onto aedd323f1e...

Current branch diff-target is up to date.
Changes applied before test
commit 4c0c37bab05a279eb015145eb2861b864c2fe161
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 10 16:09:53 2020 +0200

    Use the automatic RPC client/server generation

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/17/ for more details.