Differential D3251

origin-visit-upsert: Write origin-visit-status to journal
ClosedPublic
Actions

Authored by ardumont on Jun 10 2020, 10:39 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2310: Make origin visits immutable

Commits

rDSTOd68c7ecfc35e: origin-visit-upsert: Write visit status objects to the journal

Summary

Related to T2310

Test Plan

happy happy tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 10 2020, 10:39 AM

Build is green

Patch application report for D3251 (id=11527)

Rebasing onto 86d05fb275...

Current branch diff-target is up to date.

Changes applied before test

commit e3bf127c6a6c35d191574eb4fbf46a898924b3d3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 10 10:29:09 2020 +0200

    origin-visit-upsert: Write origin-visit-status to journal
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/252/ for more details.

Harbormaster completed remote builds in B12731: Diff 11527.Jun 10 2020, 10:46 AM

ardumont added inline comments.Jun 10 2020, 10:46 AM

swh/storage/storage.py
1016	I've removed that todo as we soon will be removing that code anyway.

Rework commit message
Rework comment about origin visit status comparison in test

Build is green

Patch application report for D3251 (id=11528)

Rebasing onto 86d05fb275...

Current branch diff-target is up to date.

Changes applied before test

commit d68c7ecfc35e3ec6bbdefdf1465769f924c900a4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 10 10:29:09 2020 +0200

    origin-visit-upsert: Write visit status objects to the journal
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/253/ for more details.

Harbormaster completed remote builds in B12732: Diff 11528.Jun 10 2020, 10:59 AM

vlorentz accepted this revision.Jun 10 2020, 11:37 AM

This revision is now accepted and ready to land.Jun 10 2020, 11:37 AM

Closed by commit rDSTOd68c7ecfc35e: origin-visit-upsert: Write visit status objects to the journal (authored by ardumont). · Explain WhyJun 10 2020, 11:48 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOd68c7ecfc35e: origin-visit-upsert: Write visit status objects to the journal.

ardumont mentioned this in T2310: Make origin visits immutable.Jun 10 2020, 3:09 PM