diff --git a/swh/loader/core/loader.py b/swh/loader/core/loader.py --- a/swh/loader/core/loader.py +++ b/swh/loader/core/loader.py @@ -396,7 +396,7 @@ def store_data(self) -> None: assert self.origin - if self.config["save_data"]: + if self.config.get("save_data"): self.save_data() if self.has_contents(): diff --git a/swh/loader/core/tests/test_loader.py b/swh/loader/core/tests/test_loader.py --- a/swh/loader/core/tests/test_loader.py +++ b/swh/loader/core/tests/test_loader.py @@ -7,7 +7,7 @@ import hashlib import logging -from swh.model.model import Origin +from swh.model.model import Origin, Snapshot from swh.loader.core.loader import BaseLoader, DVCSLoader @@ -24,9 +24,6 @@ def fetch_data(self): pass - def store_data(self): - pass - def get_snapshot_id(self): return None @@ -55,6 +52,24 @@ }, } + def get_contents(self): + return [] + + def get_directories(self): + return [] + + def get_revisions(self): + return [] + + def get_releases(self): + return [] + + def get_snapshot(self): + return Snapshot(branches={}) + + def eventful(self): + return False + class DummyBaseLoader(DummyLoader, BaseLoader): """Buffered loader will send new data when threshold is reached @@ -84,6 +99,9 @@ }, } + def store_data(self): + pass + def test_base_loader(): loader = DummyBaseLoader()