Differential D3186

*.sql
ClosedPublic
Actions

Authored by vlorentz on May 28 2020, 10:22 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO1aff3c6d155b: Add a pre-commit hook to check there are version bumps in sql/upgrades/*.sql

Summary

Catches mistakes such as D3185.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 28 2020, 10:22 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 28 2020, 10:22 AM

Nice!

This revision is now accepted and ready to land.May 28 2020, 10:26 AM

Build is green

Patch application report for D3186 (id=11326)

Rebasing onto 3613438f36...

Current branch diff-target is up to date.

Changes applied before test

commit 1aff3c6d155b2363442220dcbc74a44e49cf6590
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu May 28 10:21:35 2020 +0200

    Add a pre-commit hook to check there are version bumps in sql/upgrades/*.sql

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/197/ for more details.

Harbormaster completed remote builds in B12519: Diff 11326.May 28 2020, 10:29 AM

Closed by commit rDSTO1aff3c6d155b: Add a pre-commit hook to check there are version bumps in sql/upgrades/*.sql (authored by vlorentz). · Explain WhyMay 28 2020, 10:40 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO1aff3c6d155b: Add a pre-commit hook to check there are version bumps in sql/upgrades/*.sql.

Revision Contents
Changeset List

Path

Size

.pre-commit-config.yaml

7 lines

Diff 11327

View Options

Add a pre-commit hook to check there are version bumps in sql/upgrades/*.sqlClosedPublicActions