Differential D3168

origin_metadata_add: Reject non-bytes types for 'metadata'.
ClosedPublic
Actions

Authored by vlorentz on May 19 2020, 6:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO8c2ee709495b: origin_metadata_add: Reject non-bytes types for 'metadata'.

Summary

The left-over jsonize() allowed passing a dict under some
circumstances, which allowed tests to pass but failed in
production.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12438
Build 18877: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 18876: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 19 2020, 6:33 PM

vlorentz mentioned this in D3169: Pass bytes instead a dict to origin_metadata_add..May 19 2020, 6:35 PM

Awesome!

Related to T2415

This revision is now accepted and ready to land.May 19 2020, 6:38 PM

Build is green

Patch application report for D3168 (id=11250)

Rebasing onto e645e63709...

Current branch diff-target is up to date.

Changes applied before test

commit 8c2ee709495b8c2677f7a60e91075f4c3df75ab3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 19 18:24:21 2020 +0200

    origin_metadata_add: Reject non-bytes types for 'metadata'.
    
    The left-over jsonize() allowed passing a dict under some
    circumstances, which allowed tests to pass but failed in
    production.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/184/ for more details.

Harbormaster completed remote builds in B12438: Diff 11250.May 19 2020, 6:39 PM

Closed by commit rDSTO8c2ee709495b: origin_metadata_add: Reject non-bytes types for 'metadata'. (authored by vlorentz). · Explain WhyMay 19 2020, 6:41 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO8c2ee709495b: origin_metadata_add: Reject non-bytes types for 'metadata'..