Page MenuHomeSoftware Heritage

webapp: admin-deposit-page: Drop swh_anchor_id* references from deposit entries
ClosedPublic

Authored by ardumont on Tue, May 19, 1:47 PM.

Details

Summary

This removes references from:

  • deposit admin cli listing deposits (drop swh_anchor_id* columns, rename "directory with origin" to "directory with context")
  • deposit.js library which parses the output from the cli to prepare data to be displayed

Related to T2412

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Tue, May 19, 1:47 PM
ardumont updated this revision to Diff 11246.Tue, May 19, 1:47 PM

Rework commit message

Build is green

Patch application report for D3167 (id=11245)

Rebasing onto d5c4aead49...

Current branch diff-target is up to date.
Changes applied before test
commit f34e345ee77bda0d57f45c3318930a4449f5354a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue May 19 13:38:42 2020 +0200

    Drop swh_anchor_id* references from Deposit model
    
    Related to T2412

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/132/ for more details.

Build is green

Patch application report for D3167 (id=11246)

Rebasing onto d5c4aead49...

Current branch diff-target is up to date.
Changes applied before test
commit f62752cfde1900ec1d9cc6c723f541ca04ae3704
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue May 19 13:38:42 2020 +0200

    Drop swh_anchor_id* references from Deposit model
    
    This removes references from:
    - deposit admin cli listing deposits
    - deposit.js library which parses the output from the cli to prepare data to be
      displayed
    
    Related to T2412

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/133/ for more details.

vlorentz accepted this revision.Tue, May 19, 8:00 PM
This revision is now accepted and ready to land.Tue, May 19, 8:00 PM
ardumont updated this revision to Diff 11256.Wed, May 20, 9:34 AM
  • Rework first commit message
  • admin/deposit.html: Drop unused columns, rename "directory with context"

For the missing tests, that's a general problem for that page.
I opened T2416 to compensate.

Build is green

Patch application report for D3167 (id=11256)

Rebasing onto d5c4aead49...

Current branch diff-target is up to date.
Changes applied before test
commit f6035638e7ef264f1af4374ee4e2096f9c2112bf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 20 09:29:06 2020 +0200

    admin/deposit: Drop unused columns and rename "directory with context"
    
    Instead of directory with origin. That columns contains the directory SWHID
    with origin, visit, anchor, and path.
    
    Related to T2398
    Related to T2412

commit 37b08276776055a6bfab739485375d48362e7631
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue May 19 13:38:42 2020 +0200

    Drop swh_anchor_id* references from Deposit model
    
    This removes references from:
    - deposit admin cli listing deposits
    - deposit.js library which parses the output from the cli to prepare data to be
      displayed
    
    Related to T2412
    Related to T2398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/134/ for more details.

ardumont retitled this revision from Drop swh_anchor_id* references from Deposit model to webapp: admin-deposit-page: Drop swh_anchor_id* references from deposit entries.Wed, May 20, 9:42 AM
ardumont edited the summary of this revision. (Show Details)