deposit: Adapt loader to use the latest deposit update api
ClosedPublic
Actions

Authored by ardumont on May 12 2020, 3:54 PM.

Details

Reviewers

moranegg
vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2398: Simplify/update the SWHIDs returned from a SWORD deposit

Commits

rDLDBASE8bd38f9bb468: deposit: Adapt loader to use the latest deposit update api

Summary

The deposit update status instruction at the end of the deposit load need to provide the extra snapshot_id when the load is successful.

Related to D3141
Related to T2398

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 12 2020, 3:54 PM

Build is green

Patch application report for D3142 (id=11162)

Rebasing onto 77941b1086...

Current branch diff-target is up to date.

Changes applied before test

commit 702ada0f1ff71a4dedb450df70b357ac55e9d9d8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue May 12 15:53:03 2020 +0200

    deposit: Adapt loader to use the latest deposit update api
    
    Related to D3141
    Related to T2398

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/33/ for more details.

Harbormaster completed remote builds in B12343: Diff 11162.May 12 2020, 3:55 PM

No test?

Ensure the deposit update api is called with the proper parameters

Build is green

Patch application report for D3142 (id=11192)

Rebasing onto 77941b1086...

Current branch diff-target is up to date.

Changes applied before test

commit 8bd38f9bb468f21f093a8a6ac37356dc917e86d9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue May 12 15:53:03 2020 +0200

    deposit: Adapt loader to use the latest deposit update api
    
    Related to D3141
    Related to T2398

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/34/ for more details.

Harbormaster completed remote builds in B12374: Diff 11192.May 13 2020, 4:53 PM

ardumont edited the summary of this revision. (Show Details)May 13 2020, 5:00 PM

vlorentz accepted this revision.May 15 2020, 12:32 PM

This revision is now accepted and ready to land.May 15 2020, 12:32 PM

Closed by commit rDLDBASE8bd38f9bb468: deposit: Adapt loader to use the latest deposit update api (authored by ardumont). · Explain WhyMay 15 2020, 12:41 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASE8bd38f9bb468: deposit: Adapt loader to use the latest deposit update api.