RPCClient can handle it properly by reraising, instead of a
generic RemoteException.
Details
Details
- Reviewers
anlambert ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T2388: Can't create cooking requests in swh-web
- Commits
- rDVAU4e19854e016b: Raise NotFoundExc within our RPC framework instead of returning 404.
Diff Detail
Diff Detail
- Repository
- rDVAU Software Heritage Vault
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3127 (id=11102)
Rebasing onto 88f861c4e6...
Current branch diff-target is up to date.
Changes applied before test
commit 8644ad68aa2fa72bbb73578c83819b5cd7570d82 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Tue May 5 17:36:49 2020 +0200 Raise NotFoundExc within our RPC framework instead of returning 404. RPCClient can handle it properly by reraising, instead of a generic RemoteException.
See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/5/ for more details.
Comment Actions
Build is green
Patch application report for D3127 (id=11103)
Rebasing onto 88f861c4e6...
Current branch diff-target is up to date.
Changes applied before test
commit 4e19854e016b740cf27d1e485d981eff4f81825b Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Tue May 5 17:36:49 2020 +0200 Raise NotFoundExc within our RPC framework instead of returning 404. RPCClient can handle it properly by reraising, instead of a generic RemoteException.
See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/6/ for more details.
Comment Actions
We should tag a new vault release once it is landed. I will update D3125 and do the same for swh-web to fix the error in production.
requirements-test.txt | ||
---|---|---|
2 | updated debian/control with python3-pytest-aiohttp with some luck, it's the right version and the build you just triggered will work ;) |
requirements-test.txt | ||
---|---|---|
2 | Nice catch, make me think that I will need to bump vault version in swh-web control file too |