Page MenuHomeSoftware Heritage
Differential D3115

Add a test checking a check-deposit task is created.
ClosedPublic
Actions

Authored by vlorentz on May 4 2020, 1:46 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDDEPcb6bc3aa5763: Add a test checking a check-deposit task is created.
Summary

That code was not covered so far.

Diff Detail

Repository
rDDEP Push deposit
Branch
test-schedule
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12240
Build 18561: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18560: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
704 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_deposit_schedule::test_add_deposit_schedules_check
authenticated_client = <rest_framework.test.APIClient object at 0x7f7503a99828> deposit_collection = <DepositCollection: {'id': 66, 'name': 'test'}> sample_archive = {'data': b'PK\x03\x04\x14\x00\x00\x00\x00\x00\x07c\xa4P\xcba\xb4c\x14\x00\x00\x00\x14\x00\x00\x00\x05\x00\x00\x00file1...ytest-0/test_add_deposit_schedules_che0/tmpc_nrbm5h', 'length': 128, 'md5sum': '93e8d45d31f8ac648e0f437a396a20f0', ...}
381 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_converters::test_convert_status_detail
375 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_converters::test_convert_status_detail_2
375 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_converters::test_convert_status_detail_3
277 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_converters::test_convert_status_detail_edge_case
View Full Test Results (1 Failed · 131 Passed)

Event Timeline

vlorentz created this revision.May 4 2020, 1:46 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 4 2020, 1:46 PM
swh-public-ci added a comment.May 4 2020, 1:48 PM

Build has FAILED

Patch application report for D3115 (id=11069)

Rebasing onto e979f58ac8...

Current branch diff-target is up to date.
Changes applied before test
commit 08c13f19bcf69f73edc7d5f23495e2d272484838
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 4 13:46:46 2020 +0200

    Add a test checking a check-deposit task is created.
    
    That code was not covered so far.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/9/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/9/console

Harbormaster failed remote builds in B12238: Diff 11069!May 4 2020, 1:48 PM
vlorentz updated this revision to Diff 11070.May 4 2020, 2:19 PM

fix type

swh-public-ci added a comment.May 4 2020, 2:20 PM

Build has FAILED

Patch application report for D3115 (id=11070)

Rebasing onto e979f58ac8...

Current branch diff-target is up to date.
Changes applied before test
commit 7411e4fbd58404df8e1657f4196ec4d792c57947
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 4 13:46:46 2020 +0200

    Add a test checking a check-deposit task is created.
    
    That code was not covered so far.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/10/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/10/console

Harbormaster failed remote builds in B12239: Diff 11070!May 4 2020, 2:20 PM
vlorentz updated this revision to Diff 11071.May 4 2020, 2:21 PM

fix import

swh-public-ci added a comment.May 4 2020, 2:24 PM

Build has FAILED

Patch application report for D3115 (id=11071)

Rebasing onto e979f58ac8...

Current branch diff-target is up to date.
Changes applied before test
commit 25dd79a850353aee3e6a60e26fe6c155b2643991
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 4 13:46:46 2020 +0200

    Add a test checking a check-deposit task is created.
    
    That code was not covered so far.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/11/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/11/console

Harbormaster failed remote builds in B12240: Diff 11071!May 4 2020, 2:24 PM
vlorentz updated this revision to Diff 11072.May 4 2020, 2:49 PM

fix test when run after other tests.

swh-public-ci added a comment.May 4 2020, 2:50 PM

Build has FAILED

Patch application report for D3115 (id=11072)

Rebasing onto e979f58ac8...

Current branch diff-target is up to date.
Changes applied before test
commit 8359128fa1c30a5c68549060f1cac48aa9cf8c6b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 4 13:46:46 2020 +0200

    Add a test checking a check-deposit task is created.
    
    That code was not covered so far.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/12/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/12/console

Harbormaster failed remote builds in B12241: Diff 11072!May 4 2020, 2:50 PM
vlorentz updated this revision to Diff 11073.May 4 2020, 2:54 PM

fix flake8

swh-public-ci added a comment.May 4 2020, 2:57 PM

Build is green

Patch application report for D3115 (id=11073)

Rebasing onto e979f58ac8...

Current branch diff-target is up to date.
Changes applied before test
commit cb6bc3aa57637779e6b2d1a7795ce63ccc664c6a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 4 13:46:46 2020 +0200

    Add a test checking a check-deposit task is created.
    
    That code was not covered so far.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/13/ for more details.

Harbormaster completed remote builds in B12242: Diff 11073.May 4 2020, 2:57 PM
ardumont accepted this revision.May 4 2020, 6:52 PM
This revision is now accepted and ready to land.May 4 2020, 6:52 PM
Closed by commit rDDEPcb6bc3aa5763: Add a test checking a check-deposit task is created. (authored by vlorentz). · Explain WhyMay 5 2020, 3:48 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEPcb6bc3aa5763: Add a test checking a check-deposit task is created..

Revision Contents
Changeset List

PathSize
swh/
deposit/
tests/
api/
84 lines

Diff 11071

View Options

swh/deposit/tests/api/test_deposit_schedule.py

Loading...
About · Developer information · Legal