Differential D3105

Move get_swh_persistent_ids function in common.identifers module
ClosedPublic
Actions

Authored by anlambert on Apr 30 2020, 2:50 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS04cc606c8722: Move get_swh_persistent_ids function in common.identifers module

Summary

That function was missed when moving identifiers related ones in 8b3e0ce543c0.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 30 2020, 2:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 30 2020, 2:50 PM

ardumont accepted this revision.Apr 30 2020, 2:53 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/web/common/identifiers.py
199	types are known, maybe make those official at the same time ;)

This revision is now accepted and ready to land.Apr 30 2020, 2:53 PM

Build is green

Patch application report for D3105 (id=11048)

Rebasing onto a69e886ca3...

Current branch diff-target is up to date.

Changes applied before test

commit 04cc606c87220aadc3c5b9ad7cdad88e64a3fe78
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 30 14:50:08 2020 +0200

    Move get_swh_persistent_ids function in common.identifers module
    
    That function was missed when moving identifiers related ones in 8b3e0ce543c0.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/112/ for more details.

Harbormaster completed remote builds in B12219: Diff 11048.Apr 30 2020, 3:00 PM

anlambert added inline comments.Apr 30 2020, 3:06 PM