Differential D3091

Use the new API for origin_metadata.
ClosedPublic
Actions

Authored by vlorentz on Apr 29 2020, 4:07 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE1e9b83cdf895: Use the new API for origin_metadata.

Summary

Mutually dependent on D2988.

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

new-metadata-storage

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12147
Build 18427: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 18426: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	122 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.deposit.tests.test_deposit::test_deposit_loading_failure_to_retrieve_1_artifact swh_config = '/tmp/pytest-of-jenkins/pytest-0/test_deposit_loading_failure_t0/loader.yml' requests_mock_datadir_missing_one = <requests_mock.mocker.Mocker object at 0x7f6a35b70a20>
	476 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.deposit.tests.test_deposit::test_deposit_loading_ok swh_config = '/tmp/pytest-of-jenkins/pytest-0/test_deposit_loading_ok0/loader.yml' requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7f6a35b16278>
	522 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.deposit.tests.test_deposit::test_deposit_loading_ok_2 swh_config = '/tmp/pytest-of-jenkins/pytest-0/test_deposit_loading_ok_20/loader.yml' requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7f6a35aa4278>
	504 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.deposit.tests.test_deposit::test_revision_metadata_structure swh_config = '/tmp/pytest-of-jenkins/pytest-0/test_revision_metadata_structu0/loader.yml' requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7f6a35b067f0>
	2 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_data
		View Full Test Results (4 Failed · 111 Passed)

Event Timeline

vlorentz created this revision.Apr 29 2020, 4:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 29 2020, 4:07 PM

Build has FAILED

Patch application report for D3091 (id=10992)

Rebasing onto fca7e4783d...

Current branch diff-target is up to date.

Changes applied before test

commit 58edc3618d801e807d6fa5c7950d7bbc33982c85
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 29 16:07:05 2020 +0200

    Use the new API for origin_metadata.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/31/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/31/console

Harbormaster failed remote builds in B12147: Diff 10992!Apr 29 2020, 4:09 PM

vlorentz edited the test plan for this revision. (Show Details)Apr 29 2020, 4:12 PM

sounds good.

swh/loader/package/deposit/loader.py
135	This is the internal deposit_read api the loader use (the one i was talking about earlier) [1] [1] https://forge.softwareheritage.org/source/swh-deposit/browse/master/swh/deposit/api/private/deposit_read.py$111-127
152	i guess those are respectively the authority and fetcher's id.

This revision is now accepted and ready to land.Apr 29 2020, 7:56 PM

vlorentz added inline comments.Apr 30 2020, 11:00 AM

swh/loader/package/deposit/loader.py
152	yes

This needs a rebase on latest loader deposit adaptations.
Then land and tag.

Otherwise, since D2988 landed and got released, we will no longer have a loader
deposit working.

rebase

Build is green

Patch application report for D3091 (id=11248)

Rebasing onto 8bd38f9bb4...

Current branch diff-target is up to date.

Changes applied before test

commit 1e9b83cdf895c9a82c4cd8be5aacc76762f4232b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 29 16:07:05 2020 +0200

    Use the new API for origin_metadata.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/35/ for more details.

Harbormaster completed remote builds in B12436: Diff 11248.May 19 2020, 2:33 PM

ardumont edited the test plan for this revision. (Show Details)May 19 2020, 2:35 PM

Closed by commit rDLDBASE1e9b83cdf895: Use the new API for origin_metadata. (authored by vlorentz). · Explain WhyMay 19 2020, 2:43 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE1e9b83cdf895: Use the new API for origin_metadata..