Page MenuHomeSoftware Heritage
Differential D3089

browse/content: Refactor metadata handling and add typing
ClosedPublic
Actions

Authored by anlambert on Apr 29 2020, 3:20 PM.

Details

Reviewers
vlorentz
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T2330: Simplify Permalinks box
Commits
rDWAPPS7bbd64d4e63e: browse/content: Refactor metadata handling and add typing
Summary

Cleanup metadata related to browsed archived objects by renaming some fields
and adding type info.

Start with content objects.

Related to T2330

Depends on D3088.

Diff Detail

Repository
rDWAPPS Web applications
Branch
content-metdata-cleanup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12191
Build 18487: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18486: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 29 2020, 3:20 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 29 2020, 3:20 PM
swh-public-ci added a comment.Apr 29 2020, 3:29 PM

Build is green

Patch application report for D3089 (id=10988)

Could not rebase; Attempt merge onto 57855a8dc5...

Updating 57855a8d..529ab7cb
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  13 +++
 swh/web/browse/snapshot_context.py                 | 116 ++++++++++-----------
 swh/web/browse/views/content.py                    |  58 +++++++----
 swh/web/common/typing.py                           |  30 ++++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 6 files changed, 148 insertions(+), 83 deletions(-)
Changes applied before test
commit 529ab7cb2b5f96c2df0f5883e5e0d133b4fdce14
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit 8a512d60c96b85f11cb5aa7f512a71a6c64b972b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/94/ for more details.

Harbormaster completed remote builds in B12142: Diff 10988.Apr 29 2020, 3:29 PM
anlambert added a child revision: D3092: browse/directory: Refactor metadata handling and add typing.Apr 29 2020, 4:22 PM
vlorentz accepted this revision.Apr 29 2020, 4:33 PM
This revision is now accepted and ready to land.Apr 29 2020, 4:33 PM
ardumont accepted this revision.Apr 29 2020, 4:33 PM
anlambert updated this revision to Diff 11002.Apr 29 2020, 5:17 PM

Rebase

swh-public-ci added a comment.Apr 29 2020, 5:34 PM

Build is green

Patch application report for D3089 (id=11002)

Could not rebase; Attempt merge onto 57855a8dc5...

Updating 57855a8d..c4f95517
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  17 +++
 swh/web/browse/snapshot_context.py                 | 116 ++++++++++-----------
 swh/web/browse/views/content.py                    |  58 +++++++----
 swh/web/common/typing.py                           |  30 ++++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 6 files changed, 152 insertions(+), 83 deletions(-)
Changes applied before test
commit c4f95517ebf3111f27d10e8522f23757a025f84e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit be38eb1abfe640562cb158cec5f8b81ec2ca2729
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/97/ for more details.

Harbormaster completed remote builds in B12156: Diff 11002.Apr 29 2020, 5:34 PM
anlambert updated this revision to Diff 11009.Apr 29 2020, 7:29 PM

Rebase

swh-public-ci added a comment.Apr 29 2020, 7:45 PM

Build is green

Patch application report for D3089 (id=11009)

Could not rebase; Attempt merge onto c8bca2af35...

Merge made by the 'recursive' strategy.
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  21 ++++
 swh/web/browse/snapshot_context.py                 | 116 ++++++++++-----------
 swh/web/browse/views/content.py                    |  58 +++++++----
 swh/web/common/typing.py                           |  30 ++++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 6 files changed, 156 insertions(+), 83 deletions(-)
Changes applied before test
commit 89d609c6c6321387da61cfd53c774355835a3c81
Merge: c8bca2af 8f118ab4
Author: Jenkins user <jenkins@localhost>
Date:   Wed Apr 29 17:37:41 2020 +0000

    Merge branch 'diff-target' into HEAD

commit 8f118ab40bbf5ce8f209d3b3b798097122b78c57
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit cf53eb0d21f2674e480d99af4a699b695b56daa5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/101/ for more details.

Harbormaster completed remote builds in B12185: Diff 11009.Apr 29 2020, 7:45 PM
anlambert updated this revision to Diff 11016.Apr 30 2020, 11:48 AM

Rebase

swh-public-ci added a comment.Apr 30 2020, 12:04 PM

Build is green

Patch application report for D3089 (id=11016)

Could not rebase; Attempt merge onto c8bca2af35...

Updating c8bca2af..7bbd64d4
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  21 ++++
 swh/web/browse/snapshot_context.py                 | 116 ++++++++++-----------
 swh/web/browse/views/content.py                    |  58 +++++++----
 swh/web/common/typing.py                           |  30 ++++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 6 files changed, 156 insertions(+), 83 deletions(-)
Changes applied before test
commit 7bbd64d4e63e3ed454aac0e07544e3845278625e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit 51f2af1e78cddedea597bb8770d51da73a4352d7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/106/ for more details.

Harbormaster completed remote builds in B12191: Diff 11016.Apr 30 2020, 12:05 PM
Closed by commit rDWAPPS7bbd64d4e63e: browse/content: Refactor metadata handling and add typing (authored by anlambert). · Explain WhyApr 30 2020, 12:46 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS7bbd64d4e63e: browse/content: Refactor metadata handling and add typing.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
browse/
116 lines81%
Loading...
views/
58 lines61%
Loading...
common/
30 lines100%
Loading...

Diff 11016

View Options

swh/web/browse/snapshot_context.py

Loading...
View Options

swh/web/browse/views/content.py

Loading...
View Options

swh/web/common/typing.py

Loading...
About · Developer information · Legal