Page MenuHomeSoftware Heritage
Differential D3084

Raise an error when serializing a naive datetime.
ClosedPublic
Actions

Authored by vlorentz on Apr 29 2020, 1:05 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDCORE0d9ce48d9d99: Raise an error when serializing a naive datetime.
Summary

There's no reason to allow this, and it's a potential source of
invalid data.

Depends on: D3082, D3083 (else, swh-storage tests will crash)

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 29 2020, 1:05 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 29 2020, 1:05 PM
vlorentz added parent revisions: D3082: hypothesis_strategies: Generate aware datetimes instead of naive ones., D3083: tests: Use aware datetimes instead of naive ones..Apr 29 2020, 1:05 PM
swh-public-ci added a comment.Apr 29 2020, 1:06 PM

Build is green

Patch application report for D3084 (id=10978)

Rebasing onto 5cd847a35d...

Current branch diff-target is up to date.
Changes applied before test
commit 833c35bcdae059a26270311777a3aa9923d46abd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 29 12:44:59 2020 +0200

    Raise an error when serializing a naive datetime.
    
    There's no reason to allow this, and it's a potential source of
    invalid data.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/9/ for more details.

Harbormaster completed remote builds in B12131: Diff 10978.Apr 29 2020, 1:06 PM
vlorentz mentioned this in D3079: tests: Fix execution after swh-storage update.Apr 29 2020, 1:06 PM
anlambert accepted this revision.Apr 29 2020, 5:22 PM
anlambert added a subscriber: anlambert.

Looks good to me

This revision is now accepted and ready to land.Apr 29 2020, 5:22 PM
vlorentz updated this revision to Diff 11129.May 7 2020, 11:22 AM

rebase

This revision was landed with ongoing or failed builds.May 7 2020, 11:22 AM
Closed by commit rDCORE0d9ce48d9d99: Raise an error when serializing a naive datetime. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCORE0d9ce48d9d99: Raise an error when serializing a naive datetime..
swh-public-ci added a comment.May 7 2020, 11:23 AM

Build is green

Patch application report for D3084 (id=11129)

Rebasing onto 0d9ce48d9d...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-10-D3084.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/10/ for more details.
Harbormaster completed remote builds in B12302: Diff 11129.May 7 2020, 11:23 AM
Revision Contents
Changeset List
PathSize
swh/
core/
api/
9 lines
tests/
15 lines
35 lines
Diff 11130
View Options
swh/core/api/serializers.py
Loading...
View Options
swh/core/api/tests/test_async.py
Loading...
View Options
swh/core/api/tests/test_serializers.py
Loading...
About · Developer information · Legal