Page MenuHomeSoftware Heritage

indexer.cli: Adapt get_journal_client instantiation
ClosedPublic

Authored by ardumont on Apr 23 2020, 4:12 PM.

Details

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12017
Build 18224: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18223: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3057 (id=10866)

Rebasing onto 6440795b9f...

Current branch diff-target is up to date.
Changes applied before test
commit 5125effd35f2b6917a846ac1172e0cb1fd874f32
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Thu Apr 23 16:10:21 2020 +0200

    indexer.cli: Adapt get_journal_client instantiation
    
    This fixes the current ci build failure [1]
    
    [1] https://jenkins.softwareheritage.org/job/DCIDX/job/tests/954/console
    
    Related to D3044

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/4/ for more details.

Build is green

Patch application report for D3057 (id=10867)

Rebasing onto 6440795b9f...

Current branch diff-target is up to date.
Changes applied before test
commit 1d0600055e5131b504df33fb2fd535ab9bd8b347
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Thu Apr 23 16:16:24 2020 +0200

    cli: Adapt journal client instantiation according to latest change
    
    This fixes the current ci build failure [1]
    
    [1] https://jenkins.softwareheritage.org/job/DCIDX/job/tests/954/console
    
    Related to D3044

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/5/ for more details.

douardda added a subscriber: douardda.

ok but IMHO something should be done, some day, to "normalize" also this command so it accepts the "standard" configuration scheme (via --config-file or the SWH_CONFIG_FILE env var). But that's another task. Thanks for the fix.

This revision is now accepted and ready to land.Apr 23 2020, 4:24 PM