Page MenuHomeSoftware Heritage
Differential D3049

codemeta: Add compatibility with PyLD >= 2.0.0.
ClosedPublic
Actions

Authored by vlorentz on Apr 23 2020, 2:32 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCIDX6440795b9f88: codemeta: Add compatibility with PyLD >= 2.0.0.
Summary

indexer build in failure [1]

since that change [2] got deployed upstream.

This commit fixes it.

[1] https://jenkins.softwareheritage.org/job/DCIDX/job/tests/945

[2] https://github.com/digitalbazaar/pyld/commit/46d2ca38c7b5c63696336eefdb543daecda622f3

Test Plan

Fixes the Jenkins build

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12003
Build 18203: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18202: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
497 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_journal_client
storage = <swh.storage.validate.ValidatingProxyStorage object at 0x7fe147aac550> indexer_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7fe147a8c588>
6 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.codemeta::swh.indexer.codemeta.merge_values
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.metadata_dictionary.maven::swh.indexer.metadata_dictionary.maven.MavenMapping.normalize_groupId
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.metadata_dictionary.maven::swh.indexer.metadata_dictionary.maven.MavenMapping.parse_licenses
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.metadata_dictionary.maven::swh.indexer.metadata_dictionary.maven.MavenMapping.parse_repositories
View Full Test Results (1 Failed · 304 Passed · 15 Skipped)

Event Timeline

vlorentz created this revision.Apr 23 2020, 2:32 PM
swh-public-ci added a comment.Apr 23 2020, 2:33 PM

Build has FAILED

Patch application report for D3049 (id=10848)

Rebasing onto 32a85a5c46...

Current branch diff-target is up to date.
Changes applied before test
commit 6440795b9f8875b99a610fa07569d2cab655fa94
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 23 14:31:00 2020 +0200

    codemeta: Add compatibility with PyLD >= 2.0.0.

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/3/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/3/console

Harbormaster failed remote builds in B12003: Diff 10848!Apr 23 2020, 2:33 PM
ardumont accepted this revision.Apr 23 2020, 2:37 PM
ardumont edited the summary of this revision. (Show Details)

Thanks.

This revision is now accepted and ready to land.Apr 23 2020, 2:37 PM
ardumont added a comment.Apr 23 2020, 2:43 PM

The failure in the test might be related to the recent journal changes [1] which just landed and got tagged (v0.0.31).

[1] D3044

ardumont edited the summary of this revision. (Show Details)Apr 23 2020, 2:49 PM

I'd be fine to integrate this nonetheless and to fix the other issue in another commit as it's unrelated.

This revision was landed with ongoing or failed builds.Apr 23 2020, 2:59 PM
Closed by commit rDCIDX6440795b9f88: codemeta: Add compatibility with PyLD >= 2.0.0. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCIDX6440795b9f88: codemeta: Add compatibility with PyLD >= 2.0.0..

Revision Contents
Changeset List

PathSize
swh/
indexer/
2 lines

Diff 10848

View Options

swh/indexer/codemeta.py

Loading...
About · Developer information · Legal