Page MenuHomeSoftware Heritage
Differential D3035

common.utils.context_processor: Check user attr existence in request
ClosedPublic
Actions

Authored by anlambert on Apr 20 2020, 2:12 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDWAPPS6cb30056a844: common.utils.context_processor: Check user attr existence in request
Summary

Fix the numerous "'WSGIRequest' object has no attribute 'user'" error
reported in production.

See https://sentry.softwareheritage.org/organizations/swh/issues/1680/?query=is%3Aunresolved

Diff Detail

Repository
rDWAPPS Web applications
Branch
fix-context-processor-error
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11923
Build 18075: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18074: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 20 2020, 2:12 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 20 2020, 2:12 PM
swh-public-ci added a comment.Apr 20 2020, 2:20 PM

Build is green

Patch application report for D3035 (id=10773)

Rebasing onto 1427f48610...

Current branch diff-target is up to date.
Changes applied before test
commit 306de5d0e0e512d07af0f71155bf11a73b40a7b8
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 20 14:10:18 2020 +0200

    common.utils.context_processor: Check user attr existence in request
    
    Fix the numerous "'WSGIRequest' object has no attribute 'user'" error
    reported in production.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/66/ for more details.

Harbormaster completed remote builds in B11902: Diff 10773.Apr 20 2020, 2:20 PM
vlorentz added a subscriber: vlorentz.Apr 20 2020, 3:21 PM

could you add a test?

anlambert updated this revision to Diff 10774.Apr 20 2020, 3:52 PM

Update: Add test

anlambert updated this revision to Diff 10775.Apr 20 2020, 3:54 PM

Update: Use simpler hardcoded URL in test

swh-public-ci added a comment.Apr 20 2020, 3:59 PM

Build is green

Patch application report for D3035 (id=10774)

Rebasing onto 1427f48610...

Current branch diff-target is up to date.
Changes applied before test
commit 910fd48e168e0c7139986771b20a86bc6a092ff7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 20 14:10:18 2020 +0200

    common.utils.context_processor: Check user attr existence in request
    
    Fix the numerous "'WSGIRequest' object has no attribute 'user'" error
    reported in production.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/67/ for more details.

Harbormaster completed remote builds in B11903: Diff 10774.Apr 20 2020, 3:59 PM
swh-public-ci added a comment.Apr 20 2020, 4:06 PM

Build is green

Patch application report for D3035 (id=10775)

Rebasing onto 1427f48610...

Current branch diff-target is up to date.
Changes applied before test
commit 4d9d0b34d956f696e8e8db9f76ca5ff016ec9732
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 20 14:10:18 2020 +0200

    common.utils.context_processor: Check user attr existence in request
    
    Fix the numerous "'WSGIRequest' object has no attribute 'user'" error
    reported in production.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/68/ for more details.

Harbormaster completed remote builds in B11904: Diff 10775.Apr 20 2020, 4:07 PM
olasd accepted this revision.Apr 20 2020, 5:17 PM
This revision is now accepted and ready to land.Apr 20 2020, 5:17 PM
anlambert updated this revision to Diff 10782.Apr 20 2020, 5:30 PM

Rebase

This revision was landed with ongoing or failed builds.Apr 20 2020, 5:31 PM
Closed by commit rDWAPPS6cb30056a844: common.utils.context_processor: Check user attr existence in request (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS6cb30056a844: common.utils.context_processor: Check user attr existence in request.
swh-public-ci added a comment.Apr 20 2020, 5:39 PM

Build is green

Patch application report for D3035 (id=10782)

Rebasing onto 6c89d4d93a...

Current branch diff-target is up to date.
Changes applied before test
commit 6cb30056a84462860b889fa365dc8578e80a6eb1
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 20 14:10:18 2020 +0200

    common.utils.context_processor: Check user attr existence in request
    
    Fix the numerous "'WSGIRequest' object has no attribute 'user'" error
    reported in production.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/69/ for more details.

Harbormaster completed remote builds in B11923: Diff 10782.Apr 20 2020, 5:40 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
common/
6 lines91%
Loading...
tests/
auth/
10 lines100%
Loading...

Diff 10782

View Options

swh/web/common/utils.py

Loading...
View Options

swh/web/tests/auth/test_views.py

Loading...
About · Developer information · Legal