Differential D3001

model: Rename OriginVisitUpdate to OriginVisitStatus
ClosedPublic
Actions

Authored by ardumont on Apr 10 2020, 11:20 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDMOD401bc17def41: model: Rename OriginVisitUpdate to OriginVisitStatus

Summary

This also adapts the hypothesis strategies, using the plural form
origin_visit_statuses. That plural form is acceptable because in our context,
the statuses are countable.

Related to T2310
Related to [1]

To be able to update names in the current D2937 D2938 D2939 (they use origin
visit update).

[1] https://hebdo.framapad.org/p/9g09-0jjinnno5y?lang=en

Test Plan

tox

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Apr 10 2020, 11:20 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 10 2020, 11:20 AM

Build is green

Patch application report for D3001 (id=10660)

Rebasing onto 6f8c66cdfa...

Current branch diff-target is up to date.

Changes applied before test

commit 401bc17def41c8e712e2d7d71b7e533d52d3afbc
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Fri Apr 10 10:43:20 2020 +0200

    model: Rename OriginVisitUpdate to OriginVisitStatus
    
    This also adapts the hypothesis strategies, using the plural form
    origin_visit_statuses. That plural form is acceptable because in our context,
    the statuses are countable.
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/36/ for more details.

Harbormaster completed remote builds in B11780: Diff 10660.Apr 10 2020, 11:21 AM

vlorentz accepted this revision.Apr 10 2020, 4:10 PM

This revision is now accepted and ready to land.Apr 10 2020, 4:10 PM

Closed by commit rDMOD401bc17def41: model: Rename OriginVisitUpdate to OriginVisitStatus (authored by ardumont). · Explain WhyApr 10 2020, 4:29 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDMOD401bc17def41: model: Rename OriginVisitUpdate to OriginVisitStatus.

ardumont added inline comments.Apr 20 2020, 4:45 PM